Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedupe pinia #2821

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix: dedupe pinia #2821

merged 2 commits into from
Nov 3, 2024

Conversation

posva
Copy link
Member

@posva posva commented Nov 3, 2024

Fix #2820

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit c4dd627
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/672737aacc5b6a0008122fca

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit c4dd627
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/672737aa51942f00087ec266

Copy link

pkg-pr-new bot commented Nov 3, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2821
pnpm add https://pkg.pr.new/pinia@2821
pnpm add https://pkg.pr.new/@pinia/testing@2821

commit: c4dd627

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (128f435) to head (c4dd627).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2821      +/-   ##
==========================================
+ Coverage   90.94%   91.24%   +0.29%     
==========================================
  Files          14       14              
  Lines        1336     1336              
  Branches      221      222       +1     
==========================================
+ Hits         1215     1219       +4     
+ Misses        120      115       -5     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit 90d8eb9 into v2 Nov 3, 2024
10 checks passed
@posva posva deleted the fix/nuxt-module branch November 3, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinia nuxt version 0.6.0+ causes error when used with pnpm monorepo
1 participant