Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #8337) test(component-slot): new child vnode gets destroyed instead of old one #8630

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

privatenumber
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I'm not confident in the quality of the fix (whether it's addressing the bug directly or indirectly) but deep-cloning the vnode in createElm when a vnode used in a previous render is encountered seems to fix the bug.

In any case, a test has been added to repro the bug.

@privatenumber
Copy link
Contributor Author

privatenumber commented Aug 9, 2018

Not sure what's up with the failed lint-flow-type test since I didn't touch the file it's throwing an error at

Edit: Looks like this direct commit bypassed the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants