Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rebuild theme-default #134

Open
wants to merge 118 commits into
base: main
Choose a base branch
from
Open

feat: rebuild theme-default #134

wants to merge 118 commits into from

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented May 14, 2024

TODOs:

  • extract and improve theme-helper package

Bugs:

  • slots is not reactive (found in layouts/Layout.vue)

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9125046679

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.759%

Totals Coverage Status
Change from base Build 9123655949: 0.0%
Covered Lines: 681
Relevant Lines: 1238

💛 - Coveralls

@Mister-Hope
Copy link
Member Author

@pengzhanbo Can you send a pr about onContentUpdate to the core repo?

@pengzhanbo
Copy link
Member

@pengzhanbo Can you send a pr about onContentUpdate to the core repo?

Done. vuepress/core#1620

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Feb 24, 2025

RFC: useData in main branch and here

@pengzhanbo

I think using theme to represent themeLocaleData could be every dangerous, all other parts for the repo is using theme and themeLocale to represent ThemeData and ThemeLocaleData, and the new theme useData() could be every confusing to visitors who want to dig into our code. Futhermore, it increase the possibility that the team members misuse themeData with themeLocaleData in future developement, as their variable name are the same from useData() and useThemeData().

I would suggest using themeLocale to represent theme locale data always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants