-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: drop CJS and use VueUse v13 #254
Changes from all commits
fe96dbc
45d3613
01f638f
90da3bd
c995559
d7f2a5e
77b45c1
ef6e36f
ae47631
19315fe
3df5c4e
a1b1ac8
9d85cc8
1a2d483
6795d5a
a38df57
a8c4ce7
0df607d
53fe1bc
d82eb9b
22e7d2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,24 +10,22 @@ on: | |
|
||
jobs: | ||
test: | ||
runs-on: ${{ matrix.os }} | ||
|
||
strategy: | ||
matrix: | ||
os: [ubuntu-latest] # macos-latest, windows-latest | ||
node: [18] | ||
node: [20] | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@master | ||
uses: actions/checkout@v4 | ||
with: | ||
persist-credentials: false | ||
fetch-depth: 0 | ||
|
||
- name: Install PNPM | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 8.7.0 | ||
- name: Enable corepack | ||
run: npm i -fg corepack && corepack enable | ||
|
||
- name: Use Node.js ${{ matrix.node }} | ||
uses: actions/setup-node@v2 | ||
|
@@ -57,15 +55,16 @@ jobs: | |
nightly-release: | ||
needs: | ||
- test | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
node: [18] | ||
node: [20] | ||
os: [ubuntu-latest] | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- run: corepack enable | ||
- run: npm i -fg corepack && corepack enable | ||
|
||
- uses: actions/setup-node@v4 | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,25 +15,22 @@ jobs: | |
strategy: | ||
matrix: | ||
os: [ubuntu-latest] # macos-latest, windows-latest | ||
node: [18] | ||
node: [20] | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@master | ||
uses: actions/checkout@v4 | ||
with: | ||
persist-credentials: false | ||
fetch-depth: 0 | ||
|
||
- name: Install PNPM | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 8.7.0 | ||
- name: Enable corepack | ||
run: npm i -fg corepack && corepack enable | ||
|
||
- name: Use Node.js ${{ matrix.node }} | ||
uses: actions/setup-node@v2 | ||
- name: Setup node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
registry-url: https://registry.npmjs.org/ | ||
cache: pnpm | ||
|
||
- name: Install dependencies | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,17 @@ | |
"name": "@vueuse/motion", | ||
"type": "module", | ||
"version": "2.2.6", | ||
"packageManager": "pnpm@8.15.5+sha512.b051a32c7e695833b84926d3b29b8cca57254b589f0649d899c6e9d0edb670b91ec7e2a43459bae73759bb5ce619c3266f116bf931ce22d1ef1759a7e45aa96f", | ||
"packageManager": "pnpm@10.6.2", | ||
"description": "π€Ή Vue Composables putting your components in motion", | ||
"author": "YaeΜl GUILLOUX <[email protected]>", | ||
"contributors": [ | ||
{ | ||
"name": "YaeΜl Guilloux (@Tahul)" | ||
}, | ||
{ | ||
"name": "Bobbie Goede (@BobbieGoede)" | ||
} | ||
], | ||
"license": "MIT", | ||
"homepage": "https://github.com/vueuse/motion#readme", | ||
"repository": "https://github.com/vueuse/motion", | ||
|
@@ -21,23 +29,16 @@ | |
], | ||
"sideEffects": false, | ||
"exports": { | ||
".": { | ||
"import": "./dist/index.mjs", | ||
"require": "./dist/index.cjs" | ||
}, | ||
"./nuxt": { | ||
"import": "./dist/nuxt/module.mjs", | ||
"require": "./dist/nuxt/module.cjs" | ||
} | ||
".": "./dist/index.mjs", | ||
"./nuxt": "./dist/nuxt/module.mjs" | ||
}, | ||
"main": "./dist/index.cjs", | ||
"main": "./dist/index.mjs", | ||
"module": "./dist/index.mjs", | ||
"types": "./dist/index.d.ts", | ||
"types": "./dist/index.d.mts", | ||
"typesVersions": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since we're not using "typesVersions": {
"*": {
"nuxt": [
"./dist/nuxt/module.d.mts"
]
}
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So should we have the following? "typesVersions": {
"*": {
"*": [
"./dist/*",
"./*"
],
"nuxt": [
"./dist/nuxt/module.d.mts"
]
}
}, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or just use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
no, just nuxt entry There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in fact Nuxt will drop support for node10 module resolution (if not yet removed), we can remove "typesVersions" entry There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nuxt still supports node 10 , so it is fine |
||
"*": { | ||
"*": [ | ||
"./dist/*", | ||
"./*" | ||
"nuxt": [ | ||
"./dist/nuxt/module.d.mts" | ||
] | ||
} | ||
}, | ||
|
@@ -79,8 +80,8 @@ | |
"vue": ">=3.0.0" | ||
}, | ||
"dependencies": { | ||
"@vueuse/core": "^10.10.0", | ||
"@vueuse/shared": "^10.10.0", | ||
"@vueuse/core": "^13.0.0", | ||
"@vueuse/shared": "^13.0.0", | ||
"csstype": "^3.1.3", | ||
"framesync": "^6.1.2", | ||
"popmotion": "^11.0.5", | ||
|
@@ -106,9 +107,8 @@ | |
"lint-staged": "^15.2.5", | ||
"nuxt": "^3.13.0", | ||
"pkg-pr-new": "^0.0.20", | ||
"prettier": "^3.2.5", | ||
"typescript": "^5.4.5", | ||
"unbuild": "^2.0.0", | ||
"typescript": "^5.8.2", | ||
"unbuild": "^3.5.0", | ||
"vite": "5.2.12", | ||
"vitest": "^1.6.0", | ||
"vue": "^3.4.38", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the main entry using
"main": "./dist/index.mjs",