chore[venom]: tests for lower dload #4471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4471 +/- ##
==========================================
+ Coverage 92.06% 92.08% +0.02%
==========================================
Files 120 120
Lines 17335 17332 -3
Branches 2935 2932 -3
==========================================
+ Hits 15960 15961 +1
+ Misses 957 954 -3
+ Partials 418 417 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
can add a #pragma: nocover here:
https://github.com/vyperlang/vyper/pull/4471/checks?check_run_id=36853136167
besides that, looks good. not sure we need sink since we are not doing hevm check. maybe we should check though that the resulting code can compile to assembly?
charles-cooper
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
just one small thing https://github.com/vyperlang/vyper/pull/4471/files#r1971364126
Co-authored-by: Charles Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture