refactor[test]: add more tests with hevm venom harness #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4493 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 120 120
Lines 17335 17335
Branches 2935 2935
=======================================
Hits 15960 15960
Misses 957 957
Partials 418 418 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
| ac = IRAnalysesCache(fn) | ||
| for p in self.passes: | ||
| obj = p(ac, fn) | ||
| self.pass_objects.append(obj) |
There was a problem hiding this comment.
this persists across test runs
| self.pass_objects = list() | ||
|
|
||
| def __call__(self, pre: str, post: str, hevm: bool | None = None) -> list[IRPass]: | ||
| from tests.hevm import hevm_check_venom |
Check notice
Code scanning / CodeQL
Cyclic import Note test
| pass_objects: list[IRPass] | ||
| default_hevm: bool | ||
|
|
||
| def __init__(self, *passes, post: list[type] | None = None, default_hevm: bool = True): |
There was a problem hiding this comment.
bit odd that pre passes are passed as varargs but post passes are passed as a list
| jmp @join | ||
| join: | ||
| %3 = phi @then, %1, @else, %2 | ||
| stop |
There was a problem hiding this comment.
maybe we should sink %3 here, otherwise hevm will trivially validate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added hevm harness to more venom tests
How I did it
rewrote tests to venom text format if needed and used hevm harness
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture