Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor section on ProblemDetails, add one possible value. #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msporny
Copy link
Contributor

@msporny msporny commented Jan 29, 2025

This PR attempts to address issue #395 by refactoring the problem details section and adding a possible value.


Preview | Diff

Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small language improvements

relating to the specifics of the endpoint on which the error occurs.
When an implementation detects an anomaly while processing a document, a
<dfn>ProblemDetails</dfn> object can be used to report the issue to other
software systems. The interface for these objects follow [[RFC9457]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
software systems. The interface for these objects follow [[RFC9457]]
software systems. The interfaces for these objects follow [[RFC9457]]

<h3>Verification Errors vs. Warnings</h3>

<p>
This specification defines a distinction between a verification error vs. a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This specification defines a distinction between a verification error vs. a
This specification defines a distinction between a verification error and a

This specification defines a distinction between a verification error vs. a
verification warning. Errors are `ProblemDetails` relating to cryptography,
data model, and malformed context and are unrecoverable. Warnings are
`ProblemDetails` relating to statuses and validity periods and might be
Copy link
Collaborator

@TallTed TallTed Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`ProblemDetails` relating to statuses and validity periods and might be
`ProblemDetails` relating to status and validity periods and might be

verification warning. Errors are `ProblemDetails` relating to cryptography,
data model, and malformed context and are unrecoverable. Warnings are
`ProblemDetails` relating to statuses and validity periods and might be
recoverable or where the subsequent action is at the discretion of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recoverable or where the subsequent action is at the discretion of the
recoverable or leave the subsequent action to the discretion of the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants