Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix bikeshed warning #1753

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

yoshisatoyanagisawa
Copy link
Collaborator

@yoshisatoyanagisawa yoshisatoyanagisawa commented Feb 12, 2025

Let me fix the following warnings by adding "-algorithm" to the ids.

WARNING: Multiple elements have the same id 'check-router-registration-limit':
  <h3> on line 3482, <dfn> on line 3482
Deduping, but this ID may not be stable across revisions. WARNING: Multiple elements have the same id 'count-router-inner-conditions':
  <h3> on line 3501, <dfn> on line 3501
Deduping, but this ID may not be stable across revisions.

Preview | Diff

Let me fix the following warnings by adding "-algorithm" to the ids.
WARNING: Multiple elements have the same id 'check-router-registration-limit':
  <h3> on line 3482, <dfn> on line 3482
Deduping, but this ID may not be stable across revisions.
WARNING: Multiple elements have the same id 'count-router-inner-conditions':
  <h3> on line 3501, <dfn> on line 3501
Deduping, but this ID may not be stable across revisions.
@yoshisatoyanagisawa
Copy link
Collaborator Author

I noticed that bikeshed warnings, and did some minor fix.
@monica-ch Will you take a look?
@sisidovski FYI

Copy link
Contributor

@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yoshisatoyanagisawa yoshisatoyanagisawa merged commit b8255db into w3c:main Feb 13, 2025
2 checks passed
@yoshisatoyanagisawa yoshisatoyanagisawa deleted the fix_warning branch February 13, 2025 00:54
github-actions bot added a commit that referenced this pull request Feb 13, 2025
SHA: b8255db
Reason: push, by yoshisatoyanagisawa

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request Feb 13, 2025
SHA: b8255db
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to yoshisatoyanagisawa/ServiceWorker that referenced this pull request Feb 14, 2025
SHA: b8255db
Reason: push, by yoshisatoyanagisawa

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants