Cleanup

w3c · Dec 18, 2024 · c9e92eb · c9e92eb
1 parent b64b3e0
commit c9e92eb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 15 deletions.
diff --git a/client/components/CandidateReview/CandidateTestPlanRun/CandidateTestPlanRun.css b/client/components/CandidateReview/CandidateTestPlanRun/CandidateTestPlanRun.css
@@ -152,3 +152,8 @@
   position: relative;
   top: -5px;
 }
+
+.begin-review-button-container {
+  margin-left: auto;
+  flex-grow: 0;
+}
diff --git a/client/components/CandidateReview/CandidateTestPlanRun/index.jsx b/client/components/CandidateReview/CandidateTestPlanRun/index.jsx
@@ -643,7 +643,7 @@ const CandidateTestPlanRun = () => {
                         </li>
                       )}
                       {isSummaryView ? (
-                        <li style={{ marginLeft: 'auto', flexGrow: 0 }}>
+                        <li className="begin-review-button-container">
                           <Button
                             ref={nextButtonRef}
                             variant="secondary"

diff --git a/client/components/FailingAssertionsSummary/FailingAssertionsSummary.css b/client/components/FailingAssertionsSummary/FailingAssertionsSummary.css
@@ -4,7 +4,6 @@
   padding: 0;
 }
 
-/* Add these rules */
 .failing-assertions-summary-table-container table {
   table-layout: fixed;
   width: 100%;

diff --git a/client/components/TestRun/TestRun.css b/client/components/TestRun/TestRun.css
@@ -54,7 +54,6 @@ button.test-navigator-toggle:focus {
   margin-top: 1em;
   font-size: 0.9em;
   padding-left: 3.25em;
-  counter-reset: list-counter;
 }
 
 .test-name-wrapper {
@@ -299,16 +298,6 @@ button.test-navigator-toggle:focus {
   counter-increment: none;
 }
 
-/* Reset counter after summary */
-.test-name-wrapper.summary + .test-name-wrapper {
-  counter-reset: list-counter;
-}
-
-/* Resume counting for non-summary items */
-.test-name-wrapper:not(.summary) {
-  counter-increment: list-counter;
-}
-
 .test-name-wrapper.summary .progress-indicator {
   background: #295fa6;
 }

diff --git a/client/tests/e2e/snapshots/saved/_candidate-test-plan_24_1#summary.html b/client/tests/e2e/snapshots/saved/_candidate-test-plan_24_1#summary.html
@@ -346,7 +346,7 @@ <h1 id="failing-assertions-heading">
                         <ul
                           aria-labelledby="test-toolbar-heading"
                           class="test-run-toolbar mt-1">
-                          <li style="margin-left: auto; flex-grow: 0">
+                          <li class="begin-review-button-container">
                             <button type="button" class="btn btn-secondary">
                               Begin Review
                             </button>

diff --git a/client/tests/e2e/snapshots/saved/_candidate-test-plan_24_1.html b/client/tests/e2e/snapshots/saved/_candidate-test-plan_24_1.html
@@ -709,7 +709,7 @@ <h1>
                               Previous Test
                             </button>
                           </li>
-                          <li style="">
+                          <li>
                             <button type="button" class="btn btn-primary">
                               Next Test
                             </button>