Expand sample test content to handle more scenarios #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stalgiag I certainly don't think the additional data support here is exhaustive. Please let me know if this aligns with your thoughts or if there are any additional pressing scenarios to cover. |
stalgiag
approved these changes
Sep 25, 2024
| } | ||
| } | ||
| } | ||
| `, |
There was a problem hiding this comment.
Thanks for cleaning up the errant indents!
| * 'incompleteAndFailingDueToUnexpectedBehaviors' | | ||
| * 'incompleteAndFailingDueToMultiple']} fakeTestResultTypes | ||
| * @param {import('sequelize').Transaction} transaction | ||
| * @param {'SINGLE' | 'ALL' | number} numFakeTestResultConflicts |
There was a problem hiding this comment.
This is a little interesting. Could you just do a number with Math.Infinity for 'ALL'? I guess it is a little strange to read 'infinity' when we really mean all. No strong feelings here but just struck me that this could be a single
testResult.scenarioResults
.slice(0, numFakeTestResultConflicts)
.forEach(setResult);There was a problem hiding this comment.
Good point! Addressed in 4b70b0b
|
|
||
| // Slightly different from older already recommended TestPlanRun 13 to get | ||
| // multiple results shown for: | ||
| // Recommended Report + Checkbox Example (Mixed-State) + NVDA + Chrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #759
This PR makes changes to the current test sample data to:
checkbox-tri-stateto have multiple advanced NVDA + Chrome Test Plan Reports to display the AT Versions Summary table/scripts/populate-test-data)