feat: Track vendor approvals across version updates through result copy process #1267
Conversation
…in as a specific vendor
howard-e
changed the title
howard-e
changed the title
…dor approval status
|
@stalgiag this is ready again for review after updating the tests |
There was a problem hiding this comment.
This is great. Thanks so much for the attention to detail in updating async and comparison code where you encountered it, adding in some utility testing methods, and writing an integration test that covers this feature. It was challenging to recreate the behavior manually but I managed with your instructions. Everything works as expected and the vendor approval status was carried over to the newer candidate version about promoting it. Great work!
| if (isLastTest) finishButtonRef.current.focus(); | ||
| // Prevent a plan with only 1 test from immediately pushing the focus to the | ||
| // submit button | ||
| if (isLastTest && tests?.length !== 1) finishButtonRef.current.focus(); |
There was a problem hiding this comment.
Great job addressing this edge case :-)
| )}'::jsonb) else element end) | ||
| from jsonb_array_elements(tests) as element ) | ||
| where id = ${id} | ||
| and tests @> '[{"id": "${testId}"}]'; |
There was a problem hiding this comment.
There is some interesting JSONB work I've never seen before, especially the containment operator. No notes, just wanted to remark.
| // Update TestPlanVersion.tests to include the viewers from the old | ||
| // TestPlanVersion.tests | ||
| // TODO: Move viewers to TestPlanReport; more appropriate and | ||
| // understandable database structure |
| ).browser.id === '3' | ||
| ).toBe(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Very impressed that you managed to reproduce this case. These tests are very helpful!
Create December 10, 2024 Release Includes the following changes: * #1279, which addresses w3c/aria-at#1163 * #1267, which addresses #1232
Address #1232