Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database management API calls and update crons #1301

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jan 8, 2025

Partially address #759 in making it easier to get a database dump from production and restoring it in staging or sandbox.

This PR adds API functions:

  • Dumping postgres database
  • Restoring postgres database
  • Cleaning up the database dumps directory so it doesn't grow too large (defaulted to max of 28 days)

This PR adds the following cron jobs:

  • Dumping postgres database every day at 00:00
  • Cleaning up the dumps directory if necessary every day at 00:05

@howard-e howard-e changed the title Add new database management API calls and update crons Add database management API calls and update crons Jan 8, 2025
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work! I see how this could make several tasks much easier. I left a few concerns inline. I may be overly cautious since I don't know the ansible environment well but if my understanding is correct here then I think we should add a couple of additional safeguards just to be careful.

server/controllers/DatabaseController.js Outdated Show resolved Hide resolved
server/controllers/DatabaseController.js Show resolved Hide resolved
server/controllers/DatabaseController.js Show resolved Hide resolved
server/controllers/DatabaseController.js Outdated Show resolved Hide resolved
server/controllers/DatabaseController.js Show resolved Hide resolved
@howard-e howard-e requested a review from stalgiag January 14, 2025 21:07
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing the feedback.

I'll leave to you to merge when you are ready @howard-e

@howard-e howard-e merged commit 2108025 into development Jan 22, 2025
2 checks passed
@howard-e howard-e deleted the database-management-and-cron branch January 22, 2025 14:26
howard-e added a commit that referenced this pull request Feb 5, 2025
Create February 4, 2025 Release

Includes the following changes:
* #1302
* #1303
* #1300, addresses #1270
* #1301, addresses #759 (additional documentation to follow)
* #1281, addresses #1241
* #1307
* #1308, addresses w3c/aria-at#1175
* #1309
* #1288, addresses #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants