Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansible-core to address package support issues #1303

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jan 13, 2025

Thursday's latest deploy to the staging environment caused an error with the following message:

ModuleNotFoundError: No module named 'ansible.module_utils.six.moves'

ubuntu-latest was recently updated to Ubuntu 24.0.1, updated from the recent 22 LTS. This suggests that the previously packaged python six module wasn't included by default in 24 as it was in 22.

Running the following would also address this error:

pip install six

But after checking the ansible-core release versions, we've long since been at EOL (Nov 2022). So I'd like to take the chance to bump ansible-core from 2.11 to 2.16. I've also confirmed this builds and deploys as expected with minimal changes to the tasks (using include_tasks or import_tasks in place of include, introduced in ansible-core 2.12).

@howard-e howard-e marked this pull request as ready for review January 13, 2025 15:57
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! The updates to the Ansible YAML files make sense with the changes you linked to in ansible. I also welcome the small improvements to formatting consistency in the README.

Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Nice work, @howard-e :)

@jugglinmike jugglinmike merged commit bac8aac into development Jan 14, 2025
2 checks passed
@jugglinmike jugglinmike deleted the ansible-bump branch January 14, 2025 18:40
howard-e added a commit that referenced this pull request Feb 5, 2025
Create February 4, 2025 Release

Includes the following changes:
* #1302
* #1303
* #1300, addresses #1270
* #1301, addresses #759 (additional documentation to follow)
* #1281, addresses #1241
* #1307
* #1308, addresses w3c/aria-at#1175
* #1309
* #1288, addresses #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants