fix: handling of commands.json aliases
#1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
changed the title
commands.json handling of aliasescommands.json handling of alias commands
howard-e
changed the title
commands.json handling of alias commandscommands.json aliases
mcking65
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
To test, I merged the compare branch for PR #1193 into the fix-alias-keys branch and made the test1197 branch and published in draft PR #1198.
The preview of the Media Seek Slider Test Plan | For Pattern: seek-slider available from PR 1198 is correctly rendering the VoiceOver tests.
This PR seems to be solving the problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
This PR does the following:
flattenObject()function'sparentKeyparam to an empty string. Without this, it was causing incorrect string matching comparisons during the review pages renders. So comparisons against"undefinedmodifierAliases.vo"when"modifierAliases.vo"was expected, would happen. This also applied tokeyAliases.flattenObject(),findValuesByKeys()andfindValueByKey()functions.This addresses a build issue discussed in #1193.