Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Practice Page for Supporting Color Contrast Settings #2991

Open
wants to merge 247 commits into
base: main
Choose a base branch
from

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Apr 15, 2024

Part of the resolution of issue #2864.

Preview Links


WAI Preview Link (Last built on Fri, 28 Mar 2025 01:25:18 GMT).

@jongund jongund requested a review from jnurthen May 22, 2024 00:16
@jongund
Copy link
Contributor

jongund commented May 22, 2024

@mcking65
This is ready for review, I think it would be great if James Nurthen could review it.

@jongund jongund marked this pull request as ready for review May 22, 2024 11:30
@jongund
Copy link
Contributor

jongund commented Mar 5, 2025

@howard-e @mcking65

The preview is not building, what do I need to do to get it working again?

@howard-e
Copy link
Contributor

howard-e commented Mar 6, 2025

The preview is not building, what do I need to do to get it working again?

@jongund the error happened because the test-contract-theme.html file was unexpected. The error is as follows:

expand error
Error: Could not determine content type for file at /home/runner/work/wai-aria-practices/wai-aria-practices/_external/aria-practices/content/practices/color-settings/test-contrast-theme.html
This file may not follow established conventions.
    at determineContentType (/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:55:9)

The preview has now built properly. I've created a temporary solution through w3c/wai-aria-practices#388 to make handling this easier and push this PR forward.

But it does highlight the brittleness of this approach so we'll eventually need to move such a configuration to this repository as the ideal solution, which I'm tracking in w3c/wai-aria-practices#389.

cc @mcking65

@jongund
Copy link
Contributor

jongund commented Mar 6, 2025

@howard-e
Don't want to make a lot of extra work, so I'll just remove the test file from the repository and put it somewhere else on the web.

@jongund
Copy link
Contributor

jongund commented Mar 6, 2025

@howard-e
I have removed the test files from the repository

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 2991 - Next steps on color settings practice.

The full IRC log of that discussion <jugglinmike> Topic: PR 2991 - Next steps on color settings practice
<jugglinmike> Matt_King: In Jon's absence, we'll skip this topic for now
<jugglinmike> github: https://github.com//pull/2991

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 2991 - Next steps on color settings practice.

The full IRC log of that discussion <jugglinmike> Topic: PR 2991 - Next steps on color settings practice
<jugglinmike> github: https://github.com//pull/2991
<jugglinmike> jongund: I made some updates based on the feedback in recent meeting minutes
<jugglinmike> jongund: It seems like Safari is the only browser that supports one requested feature
<jugglinmike> jongund: I'm concerned that including it may suggest to readers to force the default color theme
<jugglinmike> Matt_King: There's a media query for this, and it's only supported in WebKit
<jugglinmike> jongund: So what should an author do with it?
<jugglinmike> jongund: it looks like it inverts images on Macs
<jugglinmike> jongund: If this were supported on all browsers, what would you tell authors to do?
<jugglinmike> Matt_King: I can't recall the utility
<jugglinmike> jongund: I did update the table to say that there is a media query which is supported in some browsers
<jugglinmike> Matt_King: So someone can tell that this is going on, but should they do anything with that information?
<jugglinmike> Matt_King: Or, put differently: if someone is running with "invert colors" turned on, is there some benefit to the author knowing that?
<jugglinmike> jongund: There are already so many things that we're telling authors to do (or at least to consider)
<jugglinmike> Matt_King: We don't want to say that authors cannot detect this (as we previously stated) because that's incorrect.
<jugglinmike> Matt_King: We can say that we don't recommend doing anything in response to it
<jugglinmike> CurtBellew: I've never played with "invert colors". The thing with "high contrast" is that things will tend to disappear if you're not careful. I don't know if that's the same with "invert colors", but could that be what it's for...?
<jugglinmike> Matt_King: Theoretically, it's impossible for something to disappear because of invert colors because everything is inverted (there is no exception)
<jugglinmike> jongund: On the Mac, it's implemented globally on a low-level of the display, so there's little-to-no room for inconsistency. Even the DOM doesn't recognize the change--when the user inverts colors, the DOM still reports the color as authored
<jugglinmike> s/color as/colors as/
<jugglinmike> Matt_King: It's very useful to tell authors NOT to do something, and it's often quite welcome...
<jugglinmike> Matt_King: What if we told authors (essentially) "don't use this media query; we don't see any benefit to it", would you be in support of that?
<jugglinmike> jongund: I think this is a non-issue. No one on this call has experience with it, and it's only supported on one browser
<jugglinmike> Matt_King: Because it's out there and because people are writing about it, I think taking a clear position is beneficial.
<CurtBellew> +1
<jugglinmike> jongund: I support the APG discouraging its use
<jugglinmike> Matt_King: Okay, so we're aligned on that
<jugglinmike> Matt_King: It looks like you've simplified the structure of the page, generally
<jugglinmike> Matt_King: Are you ready for additional review?
<jugglinmike> jongund: I'm still making changes in response to some of your feedback. I should finish that later today
<jugglinmike> jongund: I will let you know when it's ready for additional review
<jugglinmike> Matt_King: Thank you very much!

@jongund
Copy link
Contributor

jongund commented Mar 26, 2025

@mcking65
I have made some updates to invert colors and the contrast theme section.

@jongund
Copy link
Contributor

jongund commented Mar 27, 2025

@howard-e
Hi howard the preview didn't seem to build, what do I need to do?

@howard-e
Copy link
Contributor

howard-e commented Mar 27, 2025

@howard-e Hi howard the preview didn't seem to build, what do I need to do?

@jongund nothing required of you here. But an infrastructure issue that needs to be investigated. The updated changes are now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants