-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs on narrow screens #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripu
added
bug
Something does not work as it should (as opposed to “it could be improved”)
enhancement
Something could be improved (as opposed to “doesn't work as it should”)
mock-up-1
About our first iteration (released ~ 20 Mar 2018)
labels
Mar 16, 2018
This was referenced Mar 16, 2018
Because of this, specs hiding/showing might appear temporarily on top of the filters
Add an extra .5em of top-padding to specs. Don't do multiple columns unless there's enough width (min 768px for 2, min 992px for 3, min 1200px for 4).
@tanyeah, @deniak: that last commit should address the two issues we mentioned today. @deniak, I tested with the same width you used (375px). This should be ready to be merged now. |
Merging myself, having discussed with @deniak just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something does not work as it should (as opposed to “it could be improved”)
enhancement
Something could be improved (as opposed to “doesn't work as it should”)
mock-up-1
About our first iteration (released ~ 20 Mar 2018)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35 (all items).
It would address #44 too, if my proposal (#44 (comment)) is accepted instead.
@deniak, item no. 4 (strip of white at the right-hand side) was caused by a combination of factors:
and forcing a line to go beyond its boundaries (I replaced it with a normal space; see diff ofindex.html
).::after
used to append the maturity pill.To solve the latter, I've changed how maturities are shown. That requires a change in
index.html
.From:
To:
Is that feasible?
(I have made the change in the first 4 specs only, for testing. You can check those.)
Wide screen, before:
Wide screen, after:
Narrow screen, before:
Narrow screen, after: