Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs on narrow screens #50

Merged
merged 11 commits into from
Mar 20, 2018
Merged

Fix bugs on narrow screens #50

merged 11 commits into from
Mar 20, 2018

Conversation

tripu
Copy link
Member

@tripu tripu commented Mar 16, 2018

Fixes #35 (all items).

It would address #44 too, if my proposal (#44 (comment)) is accepted instead.

@deniak, item no. 4 (strip of white at the right-hand side) was caused by a combination of factors:

  • A spec title containing   and forcing a line to go beyond its boundaries (I replaced it with a normal space; see diff of index.html).
  • Rules ::after used to append the maturity pill.

To solve the latter, I've changed how maturities are shown. That requires a change in index.html.

From:

<h2 class="ProposedEditedRecommendation">
    <a href="https://www.w3.org/TR/2016/PER-vibration-20160818/"
        title="Latest draft of Vibration API formally approved by the group">
        Vibration API
    </a>
</h2>

To:

<div class="profile">PER</div>
<h2>
    <a href="https://www.w3.org/TR/2016/PER-vibration-20160818/"
        title="Latest draft of Vibration API formally approved by the group">
        Vibration API
    </a>
</h2>          

Is that feasible?
(I have made the change in the first 4 specs only, for testing. You can check those.)


Wide screen, before:

image

Wide screen, after:

image

Narrow screen, before:

image

Narrow screen, after:

image

@tripu tripu added bug Something does not work as it should (as opposed to “it could be improved”) enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018) labels Mar 16, 2018
@tripu tripu requested review from deniak and tanyeah March 16, 2018 13:23
Add an extra .5em of top-padding to specs.
Don't do multiple columns unless there's enough width
(min 768px for 2, min 992px for 3, min 1200px for 4).
@tripu
Copy link
Member Author

tripu commented Mar 19, 2018

@tanyeah, @deniak: that last commit should address the two issues we mentioned today. @deniak, I tested with the same width you used (375px). This should be ready to be merged now.

@tripu
Copy link
Member Author

tripu commented Mar 20, 2018

Merging myself, having discussed with @deniak just now.

@tripu tripu merged commit f5c7276 into master Mar 20, 2018
@tripu tripu deleted the tripu/fix-35 branch March 20, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as it should (as opposed to “it could be improved”) enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant