-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Procedures related to Optional Features #182
Merged
+303
−291
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cab2b66
Update signing procedures in section "Base Proof Serialization".
Wind4Greg b5c8bc0
Update proof generation procedures for optional feature API updates.
Wind4Greg cade589
Update Optional Feature description and summary tables.
Wind4Greg 792549b
Update proof verify related procedures.
Wind4Greg bb3e984
Update Procedures related to Optional Features: wording and punctuati…
Wind4Greg 3a13067
Replace L variable name with longer lengthBBSMessages name. Fix up us…
Wind4Greg 46c9b0c
Update Procedures related to Optional Features: wording and punctuati…
Wind4Greg 26d2c19
Technical change to fix an off by one error.
Wind4Greg e748287
Update Procedures related to Optional Features: wording improvements.
Wind4Greg 01a6d3f
Update test vectors based on IETF Blind BBS and Pseudonym draft upda…
Wind4Greg b6e2835
Formatted JSON files.
Wind4Greg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"pidHex": "2121e748cf836c7c46a347c6fbd62ffae184c2293128b50770a455049870b2c3" | ||
"pidHex": "2121e748cf836c7c46a347c6fbd62ffae184c2293128b50770a455049870b2c3" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"pidHex": "5105adaaa2b9d6a48a9ab9e46471b40d875febc15d35663016ddb5461619d6d1" | ||
"pidHex": "5105adaaa2b9d6a48a9ab9e46471b40d875febc15d35663016ddb5461619d6d1" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"secretProverBlind": "5e5510fb904fc539698fabb7c26b0091f18f452e42f5f95671b3d0f6c1862f63", | ||
"commitmentWithProof": "b1e6740c8149a0eadd69a69da61b1b733fc4bc869a906e7b3b7f4d98bf6d8c46720dda2b60298d3676d1d2f8b7da307105683e1dde492879ea39fc665feeb3a7eb4f46e852337a762f23957968ad77e8220f656c2364c3a75a5eb66469ef956a06f5f875a74bc329cf92b25afc2f220121ae54d446cee7628d5824216dc1c2c6a2474869500c1254cb0f72cb3f181eef" | ||
"secretProverBlind": "14c6dd50a5ae34ae83cd585dda6bb0ebbc23327ad3bcc92f321f09cc954435f0", | ||
"commitmentWithProof": "b12a3bc39c35ca52631dfe4aee47f5f10d94107fd97f1aa39a94badb291ee66adf650770e08bb280af9340f34836b7ab353365d5769a24ded4a919c598c8831c0b66f83759f32d3b7eddcabf42bc471b475533116151674faec83c4fddc1c514af239f6370359aa03a955751a6b106911b902ae4dc6f14cfda9e0be04d85a3f1105fb7d5c83d263e0ca95217c8017e91" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
{"adjMandatoryIndexes":[0,1,2,5,6,8,9],"adjSelectiveIndexes":[0,1,5,7,10,16]} | ||
{ | ||
"adjMandatoryIndexes":[0,1,2,5,6,8,9], | ||
"adjSelectiveIndexes":[0,1,5,7,10,16] | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,8 @@ | ||
{"bbsProof":"85a6b563ffb00e3c270af237f1e7e16f4d35928b170012a4860553dd6c35669bd24994ba970842352ccb618ddb8e54bd8db3cc40892362313e3c0af8b3a731f3f3999baf056e2d6a5f0d6123cd6b1ab4e2362a1df78b8d22df22f7dbb0526b7795121acc388e0654e2629936f9000136488a2d623b560fdb027413cf108c9b9cfcb5a7ec32b343eff24248bec103a83e58cfd85587f3ecbd4975f41e1fef986b8beda5ab64f0183146723d234ddb676d3c1441084c73614244db83bdb215f0c665a089de186183a3de909439568041f72aa979ea496322e48eecfa5b8973c0c86335edaef58b68b9fe950fc6cbe9545269d867d4822832920f71caea384a7c6c31398456f33b5b57d395ea555eac89a267a329353bead5d31191f634c0a7737a9388cb055698e46afa32b78c29e489de5caf473e55569dc433abb6c3a44b02f3ea4af1d0d1529be2e85faed020026d622e7f7520acdb8510dc5521a4585cdc19fb9e7e6aff1f850c030a5644ffef658d3990d6aeffab20aebc818bcae9b82a1428db81e878b1e99c7035f801c5dc98b65a2088a27e93633fac10517391b20a2f767e73459cbab17de378afaa6171bd900a109d600083e679aa470ad330475ee2ef41c0c9d2716008a8dce90b8efd9b08507e4fa1ac3d7c906ac7487d32d4c4ddcda67900b166ca5e3669fb21d550fb8935ccdfedaf31e63ee25700e98577a02defd27247c524259bb317856bfb40cce82c5053288dcef017dc0e136f8c926756d38648c185d4d4423da7b5925d3fc38538d90964d35e9c76760f3589c6a63bfaba9a73d90e1d77efb5fa09b8f397d33954e59dd4532aed783be7f5922200ac52b6e598c9e4ea69277ab8e91ce3bea04947aa74b0113cb54a88cd96eb248cab956099af4c2ca7c3f8007b43be5b0e67b029baef96221554808735d0eecb8badf15a3456d1aae4e9ccf4151e7cc24fd6db7347f3cdebcaa820d4fdf7273399b02c5009678089d1cbd19e55bcb2203accd965c23ef1254c776466b458215ab53acc3c47438c3815944636b7a312240423b632e56fa635719106a891c41634102c7058f7554ab74e394012a5a1f69726cdf4499153f2b2828c34015a110d6ada0e37b77d0113b5cb830bb61796bfd2efc94c49b870eb450120f4e46fafc8f0236b30e8409a5dfc6c16880b719f8a37d66c9135b5246d1e891cd3559712d8cb35f550d1c76442ebe0b20babdd3ab9b8cc6380","labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]},"mandatoryIndexes":[0,1,2,5,6,8,9],"adjSelectiveIndexes":[0,1,5,7,10,16],"blindAdjDisclosedIdxs":[2,3,7,9,12,18],"presentationHeader":{"0":17,"1":51,"2":119,"3":170},"featureOption":"anonymous_holder_binding"} | ||
{ | ||
"bbsProof":"8621d7b34d4e0a2eae538d4a24b75b353518b9b2b4fd8e1d1131c33bb7b0708de00592ea8e959f05d278dc1ae449f68f87651657392d7d92cdfc23c967f4bd7ccb5d7e51201730aacb8ea15fc3667ee9ffad64e87e840cf9af5630b8f895b9cf8298dbdabdcf83b86038a152f668c572ec0ac2a5671a60e9ff55f01a6e937d0304cc525ac0386d500c17a52997c247ad23e0c5dfa1987e33fb14c5a44edcce4d7060fb9bdefc60e18e1328ad1824572741edb84314c3dc446b22e9891c13d200f240ec32859d96a63dc4b962a45160851bc7dfb2b5ab3c8e469cbfa2370e04b022221d30bffed0a759bde1c2d56363b543b6faa59f7dfeee8eaea1db0e73c0932a77ce39bc3b1f8008af4a8c20a630e7716e9fbe5636ae1ce30f6c1373b0cec62d803532a8101f633d7260fdba6e55ba36956cf3bbd9aae52193a108b4012b12e67d7a51498e44b10430aadc3857eef73e7bfa34b0aebd511823dae91cf29b68c618a7b3b7b804e97d599a92efd895975309e19edd932474534f3a447cf9c4d3cc228559ff70c17d2ee3544c9ba5051c43feedc9a02acd185a339f0307fb80cf209955368f60a0fd18d55efb249f22a805249bc6ec8cba9be2b4237e8866460cc4d063f16e0cb2fe82ad9b229d565d3c472c5e574fec5867ad90ed41c8a87e4e59f513bb937309f6135923950f119fcf6f7e682ea2917120f6830f38ff3bad1057908555d5cb884f2a4775e22cb311ee67355fe474e93a26129995c03ec4f76b4e4d191391a5e03f49e72f72971b35d2164f30717d7ce906d822bd7c993eecdbcf4ecfd0b0edb1f0dbf73de2a1cc7d0c34a5b2cff4dee896ce12c9a1d4b4f48f7a50918685c7007854d98945dc6563515377cc50fc2e47ac23a1bda1f9fcacdd4fa5519edc27250640d93a7358a48c6b733235c6ef4683e4a78f5b3da71be9cdaf153a26290becc72578b414a2a5d3c33c01bf7026a06dd7c5cedb9aa7b661507718631f84b47ee3a78331ef9a9abccf389a06521a598ffba6aff68cd31a982a67a11f2dd3cefdf5a3447688ddb24e97686373ab5efab6438586022f0cc7844355057e2f7bdb9fee7ad1661635a8056401df5b48b9958d92874c8d44119479d69d16ebb82ec741e8ffe1175e1bf7732038fe02a2063f83e0e11a77ebd37e146a0b59b39adc653255acfe19f5a5fc21db139652cb085d7c49ebe6bee66f3e9c9a888bb0679bf570e862c3cb68867cf401", | ||
"labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]}, | ||
"mandatoryIndexes":[0,1,2,5,6,8,9],"adjSelectiveIndexes":[0,1,5,7,10,16], | ||
"presentationHeader":{"0":17,"1":51,"2":119,"3":170}, | ||
"featureOption":"anonymous_holder_binding", | ||
"lengthBBSMessages":23 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
{"combinedIndexes":[0,1,2,3,4,5,6,10,11,13,14,17,23],"mandatoryIndexes":[0,1,2,5,6,11,13],"nonMandatoryIndexes":[3,4,7,8,9,10,12,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29],"selectiveIndexes":[3,4,5,6,10,14,17,23]} | ||
{ | ||
"combinedIndexes":[0,1,2,3,4,5,6,10,11,13,14,17,23], | ||
"mandatoryIndexes":[0,1,2,5,6,11,13], | ||
"nonMandatoryIndexes":[3,4,7,8,9,10,12,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29], | ||
"selectiveIndexes":[3,4,5,6,10,14,17,23] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"secretProverBlind": "411d47e55b97a12bd31b0add394dc2333c91ee57ef7a63fa7e30e8038f270b84", | ||
"commitmentWithProof": "b5042fe80b2e07de4a489ad9288749b6dae3e203df856ae5376f09f714d4b6890f8acfd5648a779be9f0848bc13479504feea135c75b35025468edd51e792f338b470842fee4eb9d29ea3a673b52a8cc01e2640850a4a2f00508083239ed44a865543ae27cd940073fda0415c1d5659e4a591a92763e33bd4d5f613d0ef7e6976c2dd41f285b447ae9f615ffba0ca9d6" | ||
"secretProverBlind": "38296aa447032739a5bd002c1a93acbd2c2e998b76b099a579f669df037119ad", | ||
"commitmentWithProof": "8cda82fbc8691463c1cd5c96d2bd259ee9510ad572669eb5edc71090abf14a5f819c34fcb356314af65b43c530dc3ef7179e8a07334088e1b612f84a170232febca7a8b54f4ae41fdf79fa1f02d581370836dec7ce0afa0f5c63c37aeb0e280711189a0ab37184d84c11117508f54cc240c632fd7178ace50fa4ec29d18910014f9004de1a819e1d4afe39006311c2d5" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
{"bbsProof":"b69470e6c413985d13a27c4da22b0efaba4c8fb010068405ad709c544fbbbeab24703b17885ad1cee48212c0aad7c125ab69c052c516ba4884f6f328e873f81d797450bac7582b2d55a980ceb2d8d470092c7d65ec0d7d62adaca85e67540862a91fafb904ae509a04e83b24713e10b2d574eba54e2583ec0abb2c78f3a07577e134d6f2e7f8310b015f70b1a9340fe51cd34b1a1dc291467d482c3c5a007a8f471244be4f5e206078167d7acc466d92242e6a950c7b5be51489b7a4d2ef73543cee6dc441bbe00f71dbee66c71b812965083e60e139ccc117e2dd1083e9dd32bc3417dc30b8b3b54f70c18b202d3e9a24424879d4e616c7b00bcc2204e6527e50ed0c53594a0970320b670288c6cde36cf676d525d1dca7a7d35af9be03f45400322595c8c5d9031f80e5733ad3c90868dd28faf2ff33062272678a83ba15efab8b79f13df256f42beda37bed0b49850daebbf347e66228a8587c52f963613126b298f12fecfc879c4742742848c6f76304f819e90b1455d28566e627bb13b758ac92f37f9ff670c8809195ca37c1ae4914ed92925f383a9d3e7dde64d88dc5988ba6a16e1501080d6a6429ed50856e16d39c3d005f4eb74244489a5f51d895429c7ac6619bd018b7e25413e39aa3bf01bdef862507f52bfb82a46f34362e49eed23acfaafb7758f1de1b6694d1738a1059186adbd7e3652aa171bf89a359daa30cd8386a94f79e93634a70f6e2ebc36528ffa958b6c03fd9629613c12558c780e52dd417b96e195111fc126306fa434e79451145db5c640de14f199db2c717d8836fea5e4413470270ad13706203ad585f1166b6691c3cc841ffe00ef8d3d6cf1bb77b586a907b64ec60167d0b05bd70c8ad9b72e25979459060d7ca024d9ff71f2ed8b7ba15a0ab3ca9688ea9ef4d10d5d3671691298ca58930d785649fd4401008618907f1917e0f2d79501413463ad2d6dfb639e590a77d86245e649768ff721d760c71d397b8322dab499fd1bb2f9cad744f1684e80c152220bb93c75cf4677dee8e13aae6e561fa4607dd87d6682b3f0ebd051b270c2240573f182a75e20d5d6c90fb2eede0a8dafed5601b4c3ac2012452f437cdcd19d15d9c3113e84da63faee192a64140b4ea31f6ebbe9d5d45f22e40133d992425b6373361fc78af4059cdc5977378f39e24e4dc80a6690ba22f72b33f137ffce69f611d64615f33dbd3a2993d4b5f35d6290ef4625a92","labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]},"mandatoryIndexes":[0,1,2,5,6,8,9],"adjSelectiveIndexes":[0,1,5,7,10,16],"blindAdjDisclosedIdxs":[2,3,7,9,12,18],"presentationHeader":{"0":17,"1":51,"2":119,"3":170},"pseudonym":"ad1306b414ece48113bc00c17c1873b44497d3b8fb1c164553ddf5cdd0575e89585e71db13941aecd34f66bc459a0e97","featureOption":"pseudonym_hidden_pid"} | ||
{ | ||
"bbsProof":"86bd0f8ade091a628c57ac60613c9001c1d5a9d00cdcb6522cb9e0adc8b053b6bb55dfe52536419410e4e413034309118a9a8262fd586e0bee6a1ea75afaa262f87a07038099cfba13961e4cdd630ece4971d0e60fa9ad42b653c0e52c3934168fe9b112885d990568b24b2181faf19a6b30a8bb4fae9424dc290fa99e5dcc699231b8981a957769fb7bacb910a7a0da05f7dc652cca5e9a99d6dea4c9a7d4be8a1194fc264008af9ab6dc6e0119e08752f64400b2d54bf9f2ddf55d2332ea35df6cc517dde4df4c5b64ad8916c2e34b4f6ebe5ac5e9ec40120c411a37f33ccab226ddfc848d425458acd6fb0da69f0b6abec4450945fb1442261890afceda991cc18cbdfd7cef2b56e6f34a5c8f6f341c0ed4ea6eec371baccc7a4c4858f5a242eb800e9f1853f9b580ab40b3e6c5735209027b2134053aa9b1a97a890f6ee177e3b51c51d18a03550031865d363f14216c0036122a0b19b040f5544747d30122d57763be7f7d5878177b299ae8a185257e8f3b4f03e37fa7db492204952a26c06851ecbbec69be37108524e4270de758af4c35c679cae9a1e72abafc754db3bc0fa7e60789b161bbe6b15051f6d46a1842376291d9c024fc5ad23086880257ad9612650e9688ef960858f296d42eda41d269cf3452fe4a34d7e53e35b49004b739fb1312bc06019ce9bfb5c5d3d652438025d4b961774bc9c6218a05d48d5416eb426e8d978fc13b07598ceda1461534b00e8538ea1cf194922a6bc0a1d5a90a9ef378579a3d10468abe516c23c26122f2da1e2cb70a16dcd420dc254c55ffc0160555add13f02b4caeef6818adc952e5ddbb11646815d95e3cb462bff2cd024cc0bd098fd5584bbcce42b2e381542651a059dcfdd1103e3d7df48254ab6f9de605dbf3e5d180d5599ee0ced2950c872e00cae2c6be10d21b343e2bf023d9101a14998d8c24d612fbc1e51185108a1126edec634cd6c1a0829ed8a596030c50fbac8c4336875acdaf78687d6f2772f62fe6df4d05a8c8d51db1d79a096df0c4d7f84f2b097d2a96cc115d1ca544c34171431998d91058e3915619a85acf5f94091f997686f7b961a2e6335edb8707d5813a6d07fe4cdb9f9232b4cff64a458bca8eb44e4e5cb18906df1beb93cff8c1a7d85b8c816e40c36edcac7227bc18d53232d0390776e6c68f028fb68721058205142e4d47f4cd36be55fe7108007948c1573bcd458d5648a5dad71ca0032b3", | ||
"labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]}, | ||
"mandatoryIndexes":[0,1,2,5,6,8,9], | ||
"adjSelectiveIndexes":[0,1,5,7,10,16], | ||
"presentationHeader":{"0":17,"1":51,"2":119,"3":170}, | ||
"pseudonym":"ad1306b414ece48113bc00c17c1873b44497d3b8fb1c164553ddf5cdd0575e89585e71db13941aecd34f66bc459a0e97","featureOption":"pseudonym_hidden_pid", | ||
"lengthBBSMessages":23 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,10 @@ | ||
{"bbsProof":"b0b5119f2273e443bb90601a355960456fff1419fa272cb210645fc0e4cae4e8279ed84f6f450af55224df84a82ee2588a7161dc825205cdac25b04deca18749b34b941bb352137574cac1e46e970e41be62e0c0b60e2d92277890349008e8a1a05f55d86b82287b96027c46f8a4ec4f6999c468f0c29b08101fe0f450825d0b23f9f00c5ca869bbe4e5207783c5c1f62c23ccd3bffe1b1d101209059de94323c39f2ce76e108929b45539bc9b455bce11378b769042482d5669c28fcc76519a7a269d19ac9ceb2bd2a5491ea268a2615b05b8eee46f1ea39a3ea2d1f2e3c6fb9d52c4b7cc096410eb23ca3468fe141523fc961fb7fc39914fee7a8c088eee710e4356780047dce5269b417927c39da64448c67d31341cc955cfd45957108481235c3eaf0c6abb9cb52d8868a3be3c146f9c27caff1ee73ba40aa402430e0e0ba8ec9df96a85424880614936eada817951ffc16bdfe245c745aee1317336a1d297d107dc55c219da55c9e6306c92ad164a11636230c1297ec4e196ca5441d48034f16740705bdcf838fe1c50e6dc2c424a5527608b23a379959d5fc9306eac11ae3a5580cc2b22160d5a78c019ccfab917a8d913f78cf3dc334fca3c3975bd9350a9e717b9b1e4de4d1ac122d0d4d9ca58f04adc1b74a1b2239d02393d5537c57df45eeb5057d21dfcce3cdb642a8ef00696079e8fb349ff58d7e29edadbc9a09cceb3c02eac309978cff345149a1e19377e1c45a762f7fb63a06480f161ad409824067059463b32f5671b300856fa3946c18322225a6af474b0e4da7264cf38fc0303b851a89217b488739c2a2cddeb619817c41cb42b1297371f4f120630ab07e7a2a24849a20182f3823c3b3b491a1f4cf3e971035da47ee2dfefd580dee080bc91ff546edbb0790f69fd86f19c78537e9dac08b0d49418305d83143b3b4375e0836a48911d4780d38ae8a58eb75167ec4e6af3e8310c4e4399383574c38390e99d6938055204b7d43f1c5ca109c136b34a85d60ce0b4aa6c74eb1ac51090ded8fdfd7bdb3714d6df29bc7c82f536382897692d1a11cf60d5808b6354816255039b992b968bde4a0e054b10f403b34b89d851c2a936cf77ec0300e232736cb990491b94dde1dfb56ac9a1efce937f4cf4627e0761d80ae206b1c92092c53bc2b4590dbef58f3042890eae70109740","labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]},"mandatoryIndexes":[0,1,2,5,6,8,9],"adjSelectiveIndexes":[0,1,5,7,10,16],"presentationHeader":{"0":17,"1":51,"2":119,"3":170},"pseudonym":"b2981ced4b1acc7ddcaef1df51de385b344d697727ad5c8aee2b60d76a349146b4995d348607363070dd47b31a558be1","featureOption":"pseudonym_issuer_pid"} | ||
{ | ||
"bbsProof":"b1e7e101612e445e05c355545a0eaeda60c4d5f6b2118bd5bab4addd3d5a74a3c7296b1947079033b37e5e7ffead71c3a67b4251662fd1bb4cdbb6ed3b5aa916fa3f41e5bfdb2352c8cd0c7c2a9c16ee5d7b4e9195a92240c9d3c7403dadddccad4628e3c761fe9bb0983fd754efc28d36cc379e747074fa7029dc11187583ed87a8ead2e2105e834539c3cf5d1e47402a228a0668ef2bb124d41a2d7f11a026612da4138ef61d67bf28867a593615c312932ad74068a4eb54e8d56728574708057c3f88a30b4b380b90dcdbdd1fb7c54b6d11d348b4f33d1567fe23015fab3283fbf29ad2641cf0672a53b16ea9f20a0fb3a7e07a1f8951db23a794fdc4b97f3f2fe1b053f68a5db2159b8034b2b3544925f8e4e407ecaf1a8f1f025eff50e9cbad11192038d0ba07fb44b33fd77a695f9ea089bc86856d8d93f3891c5d230f0d2d4930d79671c9e8e8de3a40487dc869d5169a5397839a49baec8f409659ee9c45b15e39b0fd482ad76beeda9d5bd3143bd3be5312828b08dc889962bf1ea45d42c8d9ba34fb40a76082e375b004990d3806e90024fe211c4dec5b104f6ba01d69916f56605e32228c7a47449e94072a4887b9460573ec8fa5e92cb6ab21bcf4a6549af5f630493f42a584d49cd8a072b53bfd030f3863f79ef66167ff6b270f396c345520872facd16d75444f9fb333ec93043f0e4dad12ef3182fedd7d6fc2e430bca67506540c61a9a9bd84d5790c1711463e78d085f91b81629c0b22f55f8241ec5c3182ecd51cfa112beee6901aef8bec9f3ae27e82e509318d989b5a6a6d794562792ac0d138a1f75faada8e40c21a4519b841b313e1b0f1c8f3e7ce8b324c95fe29c202a3678f184ee7b70a10998fd6d80698b322f12806cc74fadc9ca2d4df487975a21e392bad0dae4add605dc5c8ad816da5cbf7ba19893d0d2388248504c375e7786ef6fffca18b0428184d25662f81f11f1dc276c71d8651367570d1263559e5d81049ee3b3c2d8eb4534367752e8b197af1d1989e1ebf55f8b71a616e49a98d09a456c0267e58cc1458997a8cfe00b499ffa91fbf0d01f5122329c9b822e981e42fa30c4e6a9511c53c2bcc34ca99350132260230296cbaf7a25ad678ef8a409b707ca78b51f016b52f571438d832b85f3c5fcfb67d7957113790616c9100684f1aaefb2335bed05a", | ||
"labelMap":{"dataType":"Map","value":[["c14n0","b1"],["c14n1","b2"],["c14n2","b0"]]}, | ||
"mandatoryIndexes":[0,1,2,5,6,8,9], | ||
"adjSelectiveIndexes":[0,1,5,7,10,16], | ||
"presentationHeader":{"0":17,"1":51,"2":119,"3":170}, | ||
"pseudonym":"b2981ced4b1acc7ddcaef1df51de385b344d697727ad5c8aee2b60d76a349146b4995d348607363070dd47b31a558be1", | ||
"lengthBBSMessages":24, | ||
"featureOption":"pseudonym_issuer_pid" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency here between referring to the function name from the appropriate BBS spec or referring to the title of the procedure section in that spec. Here we use the function name (
BlindProofGen
) and below we use the section titleCalculate Pseudonym
andHidden PID Proof Generation with Pseudonym
. We should pick one of these and me consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlongley yes, when the draft IETF specs didn't have a function name (pseudonym signing) I used section names. Then I dropped the parenthesis after function names, i.e.,
BlindProofGen()
is actually a function that is defined. Ideas/preferences for consistency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer the function name (and the parenthesis can be omitted) because it's shorter and more specific for implementers. I can live with full titles as well if people want that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping on this -- it can be handled in another PR if necessary, but we should get consistency at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency is good. Clarity is better.
Is
BlindProofGen
a function or a procedure?Is
Calculate Pseudonym
a procedure or a function?I believe I've seen both procedures and functions (elsewhere) named with Pascal case. I think I've only seen multi-word names on procedures, not functions.
I think including the
()
helps clarify that the thing being discussed is a function, as I don't think I've ever seen a()
suffix on a procedure name.All of which to say — I would prefer to keep the
()
and use Pascal- or camel-case to name functions, and to use multi-word names for procedures, and to always be explicit aboutfunction
calls vsprocedure
runs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wind4Greg have @TallTed's issues been addressed? I'd like to merge this PR, but not until we've addressed @TallTed's concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @msporny not quite sure what to do about @TallTed's concerns some of the inconsistent naming comes from the IETF drafts. I'm not sure we differentiate between
functions
andprocedures
as terms. If there is something concrete that needs to be changed happy to update.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be consistent with what we call these things. As someone not familiar with some of this new text, I'd question what the difference is between a "function" and a "procedure". I'd be worried that I am missing something important when seeing those words if they're used interchangeably. IOW, we should pick one and be consistent in its usage. I suggest we use the word "algorithm" throughout all of the specifications as I believe that's what we do throughout the other specifications.
I try to avoid the use of the word "function" because some developers believe it to be referring to a software library call.
I avoid the word "procedure" because readers believe it's a loosely defined set of tasks where the implementation details are unimportant.
I use the word algorithm because it doesn't have the same connotations as "function" nor "procedure" -- it is more abstract than a function but less abstract than a procedure.
Can we update ALL of the references to refer to "algorithms" and NOT use the
()
notation because that implies a concrete function (which the IETF specifications are not).