add option to use inline styles for positioning #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wagerfield can this be approved? See use case: https://stackoverflow.com/questions/74942946/how-to-disable-parallax-js-on-element-click/74943055#74943055 Currently, one must either override the inline styling through JS or use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues #242 and #273.
In some cases, using inline styles for positioning parallax elements forces developers to override css properties with
!important, which is inelegant at best and impossible at worst.I added a
useInlinePositionoption (set to true, which is the current behavior, so it does not break anything) to stop using inline positioning for parallax elements.I did not update the data attribute API because this is a behavior which is normally decided on website level, not element-by-element.