Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(REST): storev3 client #1100

Merged
merged 2 commits into from
May 14, 2024
Merged

feat(REST): storev3 client #1100

merged 2 commits into from
May 14, 2024

Conversation

richard-ramos
Copy link
Member

Description

Adds an endpoint for storev3

@status-im-auto
Copy link

status-im-auto commented May 13, 2024

Jenkins Builds

Click to see older builds (2)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 279bf94 #1 2024-05-13 16:25:11 ~2 min nix-flake 📄log
✔️ d416e08 #2 2024-05-13 20:52:23 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c731def #3 2024-05-14 06:00:49 ~1 min nix-flake 📄log
✔️ 271f5c0 #4 2024-05-14 12:25:24 ~1 min nix-flake 📄log

Copy link

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

cmd/waku/server/rest/store.go Outdated Show resolved Hide resolved
cmd/waku/server/rest/store_api.yaml Show resolved Hide resolved
cmd/waku/server/rest/store.go Show resolved Hide resolved
cmd/waku/server/rest/waku_rest.go Outdated Show resolved Hide resolved
cmd/waku/server/rest/store.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it as only minor comments required to be addressed.

@richard-ramos richard-ramos merged commit 7028a0b into master May 14, 2024
11 of 12 checks passed
@richard-ramos richard-ramos deleted the rest-store-v3 branch May 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants