fix: allow peer-selection without pubsubTopics #1112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| continue | ||
| if len(criteria.PubsubTopics) > 0 { | ||
|
|
||
| pm.logger.Debug("discovering peers by pubsubTopic", zap.Strings("pubsubTopics", criteria.PubsubTopics)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
|
Closing this PR as this is not a required feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that peer-selection always assumes supported pubsubTopics are known for a peer.
Added a functionality to not use pubsubTopic filter as selection if it is not passed in selectionCriteria.
But not sure if this is a valid peer selection mechanism.
Considering peers that are discovered in status-go seemed to get added without pubsubTopic list.
Note: I am not 100% sure if this is required. Will keep this in draft until i get clarity.