fix: check subscription when relay publish message #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaichaosun
requested review from
richard-ramos and
chaitanyaprem
as code owners
plopezlpz
approved these changes
Aug 28, 2024
kaichaosun
commented
Aug 29, 2024
richard-ramos
approved these changes
Aug 30, 2024
kaichaosun
force-pushed
the
check-subscribe
branch
from
2798423 to
1e231fc
Compare
| @@ -280,12 +280,20 @@ func (w *WakuRelay) Publish(ctx context.Context, message *pb.WakuMessage, opts . | |||
| if err != nil { | |||
| return pb.MessageHash{}, err | |||
| } | |||
| _, err = w.subscribeToPubsubTopic(params.pubsubTopic) | |||
There was a problem hiding this comment.
why subscribe only in case pubsubtopic is empty?
shouldn't we return errro in this case as well simliar to line 294
There was a problem hiding this comment.
For relay REST API, it supports publish a message without pubsubTopic, this is a quick fix for it.
Not sure if there's a better way for this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to: #1207
Changes
Tests