feat: increase outbound q size for pubsub #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
while going through logs in status-desktop relay mode, i had noticed following log occuring quite consistently.
DEBUG[09-05|06:35:08.182|go.uber.org/zap/sugar.go:198] dropping message to peer 16Uiu2HAmGAA54bBTE78MYidSy3P7Q9yAWFNTAEReJYD69VRvtL5r: queue full
On quick analysis, noticed that this is happening towards almost all peers.
In a span of
~24 hours
i could see similar logs towards almost200
peers which shows that we need to increase queue-size that might be causing this.This may help improve message reliability as messages would not be dropped towards peers be it control msgs at gossipsub layer or application messages.
Changes
Tests
dogfooding in progress, will update with results