Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make criteriaFN public #942

Merged
merged 3 commits into from
Dec 4, 2023
Merged

feat: make criteriaFN public #942

merged 3 commits into from
Dec 4, 2023

Conversation

richard-ramos
Copy link
Member

Description

This change is required to be able to override the default factory store

@status-im-auto
Copy link

status-im-auto commented Nov 30, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (1)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 7002d46 #1 2023-11-30 20:18:34 ~54 sec nix-flake 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 151be02 #2 2023-11-30 20:33:13 ~1 min nix-flake 📄log
✔️ 111522b #3 2023-12-04 19:39:13 ~1 min nix-flake 📄log

@richard-ramos
Copy link
Member Author

Ha! just noticed there was already a Timesource() function in the code

@richard-ramos richard-ramos changed the title feat: add Timesource() to wakunode, and make criteriaFN public feat: make criteriaFN public Nov 30, 2023
chaitanyaprem
chaitanyaprem approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 13e2d7a into master Dec 4, 2023
10 checks passed
@richard-ramos richard-ramos deleted the refactor-store-timesource branch December 4, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-ramos @status-im-auto @chaitanyaprem