-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CI should have human readable logs + json for reporting #2241
Conversation
size-limit report 📦
|
289fc62
to
a528f27
Compare
@@ -47,14 +49,17 @@ jobs: | |||
|
|||
- run: npm run build:esm | |||
|
|||
- name: Create reports directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we create and save reports? Is it to be displayed in the pipeline later?
I know before we were doing so to push allure reports but why this one is done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar situation, we generate the reports and use GH UI to display it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good but test reporting has failed
a528f27
to
76ec0d5
Compare
Moving to draft for now based on:
https://discord.com/channels/1110799176264056863/1333438262013989018/1334858240235929632 |
redundant based on allure merge back |
Problem / Description
We recently switched to a JSON reporter for our tests.
This created a side-effect where logs were now being printed in JSON, instead of human-readable format (spec)
Solution
Use multi-reporter:
spec
(human readable) for logs (stdout)Checklist