Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HealthIndicator with simplified logic and testing #2251

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Feb 4, 2025

Problem / Description

After recent refactoring HealthManager E2E tests and implementation we broken and out of sync.

Solution

This PR consolidates logic of health state defined in the spec, moves it into SDK level, lightens it's testing only with unit tests and

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@weboko weboko requested a review from a team as a code owner February 4, 2025 19:10
Copy link

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 84.73 KB (+0.16% 🔺) 1.7 s (+0.16% 🔺) 8.6 s (-24.5% 🔽) 10.3 s
Waku Simple Light Node 135.69 KB (+0.02% 🔺) 2.8 s (+0.02% 🔺) 13.9 s (+53.06% 🔺) 16.6 s
ECIES encryption 22.81 KB (+0.34% 🔺) 457 ms (+0.34% 🔺) 3.5 s (-30.22% 🔽) 3.9 s
Symmetric encryption 22.23 KB (+0.02% 🔺) 445 ms (+0.02% 🔺) 2.5 s (-29.37% 🔽) 2.9 s
DNS discovery 70.81 KB (+0.03% 🔺) 1.5 s (+0.03% 🔺) 11.9 s (+27.8% 🔺) 13.3 s
Peer Exchange discovery 71.71 KB (-0.12% 🔽) 1.5 s (-0.12% 🔽) 7.6 s (-14.21% 🔽) 9.1 s
Local Peer Cache Discovery 65.39 KB (+0.02% 🔺) 1.4 s (+0.02% 🔺) 9.7 s (+20.48% 🔺) 11 s
Privacy preserving protocols 76.53 KB (+0.02% 🔺) 1.6 s (+0.02% 🔺) 9 s (+19.85% 🔺) 10.6 s
Waku Filter 78.09 KB (-0.04% 🔽) 1.6 s (-0.04% 🔽) 11 s (-1.01% 🔽) 12.5 s
Waku LightPush 75.3 KB (-0.5% 🔽) 1.6 s (-0.5% 🔽) 11.8 s (+2.78% 🔺) 13.3 s
History retrieval protocols 75.72 KB (-0.07% 🔽) 1.6 s (-0.07% 🔽) 11.2 s (+109.98% 🔺) 12.7 s
Deterministic Message Hashing 7.33 KB (+0.04% 🔺) 147 ms (+0.05% 🔺) 2.2 s (-17.8% 🔽) 2.3 s

@weboko weboko merged commit 3136f3a into master Feb 5, 2025
10 of 11 checks passed
@weboko weboko deleted the weboko/health-state branch February 5, 2025 12:24
@weboko weboko mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: HealthManager should provide an events-based API
2 participants