Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separating heaptrack from debug build #3249

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jan 23, 2025

Description

Debug builds currently include heaptrack. In this PR, we separate heaptrack from debug builds, and rename the Dockerfile debug target to prod-with-heaptrack which is more accurate.

Changes

Issue

#3236

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3249

Built from 346b256

@gabrielmer gabrielmer marked this pull request as ready for review January 23, 2025 14:59
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable! Thank you.

@gabrielmer gabrielmer merged commit 81f24cc into master Jan 24, 2025
11 of 15 checks passed
@gabrielmer gabrielmer deleted the chore-separate-heaptrack-from-debug branch January 24, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants