chore: refactor filter to react when the remote peer closes the stream #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better control when the remote peer closes the WakuFilterPushCodec stream remotely. For example, go-waku closes the stream for every received message. On the other hand, js-waku keeps the stream opened. Therefore, we support both scenarios.
Ivansete-status
force-pushed
the
better-filter-approach
branch
from
e3cf52a to
9d004e4
Compare
|
You can find the image built from this PR at Built from aa2632a |
gabrielmer
approved these changes
Feb 6, 2025
NagyZoltanPeter
approved these changes
Feb 6, 2025
Good point! Something to consider in the future if other projects may benefit from that as well: @richard-ramos |
Ivansete-status
added a commit
that referenced
this pull request
Feb 6, 2025
#3281) Better control when the remote peer closes the WakuFilterPushCodec stream. For example, go-waku closes the stream for every received message. On the other hand, js-waku keeps the stream opened. Therefore, we support both scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better control when the remote peer closes the WakuFilterPushCodec stream remotely.
For example, go-waku closes the stream for every received message. On the other hand, js-waku keeps the stream opened. Therefore, we support both scenarios.
Issue
closes #3271