Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Unsubscribe #7

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Filter Unsubscribe #7

merged 3 commits into from
Dec 18, 2023

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Dec 14, 2023 •
edited
Loading

  • Added filter unsubscribe and unsubscribe all tests
  • reached 92 tests

Issues reported:

  1. gowaku:

    • Strage error when retrieving messages
    • Reopened and closed again the log flood issue

  2. nwaku:

@fbarbu15 fbarbu15 changed the title Tests/filter unsubscribe Filter Unsubscribe Dec 15, 2023
@fbarbu15 fbarbu15 marked this pull request as ready for review December 15, 2023 09:46
romanzac
romanzac reviewed Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about "pring_filter_subscriptions(request_id)" in src/node/waku_node.py. Have you wished the name "pring..." or is it a typo?

@fbarbu15
Copy link
Collaborator Author

Just a question about "pring_filter_subscriptions(request_id)" in src/node/waku_node.py. Have you wished the name "pring..." or is it a typo?

Typo :D
Fixed

@fbarbu15 fbarbu15 requested a review from romanzac December 15, 2023 14:49
romanzac
romanzac approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual!

@fbarbu15 fbarbu15 merged commit 26718c3 into master Dec 18, 2023
1 of 2 checks passed
@fbarbu15 fbarbu15 deleted the tests/filter-unsubscribe branch December 18, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanzac romanzac romanzac approved these changes

@AlejandroCabeza AlejandroCabeza Awaiting requested review from AlejandroCabeza

@AlbertoSoutullo AlbertoSoutullo Awaiting requested review from AlbertoSoutullo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarbu15 @romanzac