Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OE/Yocto SDK mitigation #2861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OE/Yocto SDK mitigation #2861

wants to merge 2 commits into from

Conversation

ch-f
Copy link

@ch-f ch-f commented Apr 1, 2023

When using OE/Yocto to create a SDK/toolchain, the generated LibwebsocketsTargets.cmake falsely contains the host path (build artifacts) in INTERFACE_LINK_LIBRARIES instead of the actually installed SDK path.

This originates from LIBUV_LIBRARIES and OPENSSL_LIBRARIES because they contain the full host path to the libraries instead of just library names (without the '-l').

There might be more full host path for different LWS features.

For reference, a similar report issue is here.

Maybe this mitigation is better addressed at meta-openembedded?

ch-f added 2 commits April 1, 2023 21:29
When using OE/Yocto to create a SDK/toolchain, the generated
LibwebsocketsTargets.cmake falsely contains the host path (build
artifacts) in INTERFACE_LINK_LIBRARIES instead of the actually installed
SDK path.

This host path originates from OPENSSL_LIBRARIES that gives the full
path to the openssl library at build time.

To avoid propagating full build host specific path to generated
LibwebsocketsTargets.cmake, this patch forces to link with ssl and
crypto instead of a full path.
When using OE/Yocto to create a SDK/toolchain, the generated
LibwebsocketsTargets.cmake falsely contains the host path (build
artifacts) in INTERFACE_LINK_LIBRARIES instead of the actually installed
SDK path.

This host path originates from LIBUV_LIBRARIES that gives the full
path to the openssl library at build time.

To avoid propagating full build host specific path to generated
LibwebsocketsTargets.cmake, this patch is using pkg_check_modules().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant