-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow: Rename docker container #168
base: main
Are you sure you want to change the base?
Conversation
arguments: | ||
- name: old_container | ||
description: The name of the old container | ||
default_value: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the default value parameter, since the actual container names will be specific to each user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just have some minor feedback around removing the default value arguments.
@14sprouj thanks for contributing and let me know your discord username if you're in our server so I can add the right badges
default_value: ~ | ||
- name: new_container | ||
description: The name of the new container | ||
default_value: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here!
I think we should remove the default value parameter, since the actual container names will be specific to each user.
I see your discord name I'll check to see if the role has been already added |
Discord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)
sproj003
Description of changes (updated or new workflows)
New workflow for renaming a docker container