Fix bugs in zz_addi, zz_subi functions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= LONG_MIN), and the non-normalization bug in zz_subi
turtle-dragonfly
added a commit
to turtle-dragonfly/bsdnt
that referenced
this pull request
Mar 11, 2024
This bug is fixed in wbhart#23, but here we add a test to demonstrate the issue, first.
|
Thank you for this fix. I would suggest adding some tests to exercise the issue(s). I made one for myself, here: https://github.com/turtle-dragonfly/bsdnt/tree/test-inf-recursion-bug |
|
I agree. Thanks for the fix, but please consider adding some tests for the new functions. The general philosophy should be one of testing every function. There should be tests for the original issue as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are corner case errors:
infinite recursion in zz_subi when c = LONG_MIN
and non-normalized result when a and c are both zero.
I fixed it by adding two new functions - not sure what the names should be (addu, addui...?).