Add Hadar Theme to h.json

[cristianvasquezc]

• I'm the package's author and/or maintainer.
• I have have read the docs.
• I have tagged a release with a semver version number.
• My package repo has a description and a README describing what it's for and how to use it.
• Any commands are available via the command palette.
• If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").

There are no packages like it in Package Control.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[braver]

Your theme seems to have some settings. Shouldn't they be exposed to the end user?

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[braver]

The bot feedback is fine, you don't need a license file. Please address my earlier feedback about the settings.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Hadar Theme
Results help

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[braver]

Your theme seems to have some settings. Shouldn't they be exposed to the end user?

☝🏻

[cristianvasquezc]

Y como hago eso de la configuración? 🤔

[braver]

You would usually have a menu entry (and a command palette entry) that allows a user to open and edit the settings.

[braver]

I'm going to close this as stale, please respond (hopefully in English, sorry about that) if you want to continue.

[jwortmann]

You would usually have a menu entry (and a command palette entry) that allows a user to open and edit the settings.

Those menu and command palette entries are already included in Sublime Text; the menu entry is under Preferences > Settings (might be different on macOS (?)) and the command palette entry is Preferences: Settings.

Note that unlike plugins, themes cannot define their own settings files, instead settings are always read from the genereal Preferences.sublime-settings file.

In theory, a theme could add another entry to open a predefined Preferences.sublime-settings file on the lefthand side, and the users setting on the righthand side, but then the built-in settings which are expected to be implemented by themes, wouldn't be visible. And I doubt that there are many themes which do it this way. Instead, I would just describe the settings in the Readme page.