Add CSS-Intellisense plugin

[id-sakurata]

• I'm the package's author and/or maintainer.
• I have have read the docs.
• I have tagged a release with a semver version number.
• My package repo has a description and a README describing what it's for and how to use it.
• My package doesn't add context menu entries. *
• My package doesn't add key bindings. **
• Any commands are available via the command palette.
• Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
• If my package is a syntax it doesn't also add a color scheme. ***
• If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
• I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is CSS-Intellisense

My package is similar to "IntelliSense for CSS class names in HTML" from vscode However it should still be added because very useful when developing html page.

[braver]

Some problems:

• sort your package correctly
• remove the package_control.json and sublime-package.json files from the package, package control will take care of those
• you shouldn't read settings on plugin load: they're always served from memory can be read at will. that way you also ensure you get the latest version of the setting as users edit them.
• similarly you will want to update your package on any changes to the settings, also when those don't happen through your specific commands - and not through polling as you're doing with with the cache refresh how. there should be event listeners you could use.

In general I understand the utility (although I wonder if a language service wouldn't be a better approach). However, it seems to be very much set up for a single project. You might want to investigate the use of project settings to allow users to set up "css_folders" for different projects. If you working on many projects those "global" settings will just continue to grow over time.

In its current state I would say the package is a bit too naive to be generally useful (although I can totally see how it works well for you). Maybe you can get others to contribute insights and maybe even code, for instance by talking about it on the Sublime forums and Discord.

[packagecontrol-bot]

Automated testing result: SUCCESS

Repo link: CSS Intellisense

Packages added:
  - CSS Intellisense

Processing package "CSS Intellisense"
  - All checks passed

[braver]

Looks like you re-formatted the entire JSON file. Please don't do that 😉

[braver]

If you have all your settings covered in your default settings file, it's better to not have those default duplicated in both settings.get calls and the defaults for the class properties. You end up effectively defining your defaults 4 times and they get out of sync (have a close look at your scopes setting for instance).

I wonder if the way you handle settings now, where they're both user settings and temporary caches, doesn't cause issues somewhere down the line. You miss out on Sublime's default handling of automatically updating settings internally whenever users change settings. You seem to end up going deeper and deeper into that rabbit hole, having to call your load_settings method every time your package wants to do anything.

Maybe it makes sense to separate "pure" settings from the caches. That way you can simply use Sublime's api to get and set settings like enabled and auto_refresh_interval. The css_folders and css_files have a more transient aspect to it. But even there I think you might benefit from separating the user setting from the current runtime's caches, and merge the two whenever you want to read those values.

[braver]

Please respond to the feedback to continue the review.