Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takeover wowtoc #8953

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Takeover wowtoc #8953

merged 2 commits into from
Jul 23, 2024

Conversation

p3lim
Copy link
Contributor

@p3lim p3lim commented Jul 17, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

The original package has been dead for 8 years and archived for ~6, and I've been given permission by @AndrielChaoti to take over the name for this new package that provides the same functionality but modernized (to use sublime-syntax) and updated to the most recent spec.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - World of Warcraft TOC

@AndrielChaoti
Copy link
Contributor

Just popping in to say that, yes, I have given them permission to take over the maintenance of the package/the original package name.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - World of Warcraft TOC

Copy link
Collaborator

@braver braver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Just one minor change to make to the entry here.

repository/w.json Show resolved Hide resolved
Co-authored-by: Koen Lageveen <[email protected]>
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - World of Warcraft TOC

@braver braver merged commit fd2cff8 into wbond:master Jul 23, 2024
2 checks passed
@p3lim p3lim deleted the wowtoc branch July 23, 2024 12:47
@FichteFoll FichteFoll added the takeover Package maintainership is changing label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants