Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eloquence syntax #8956

Merged
merged 2 commits into from
Aug 23, 2024
Merged

eloquence syntax #8956

merged 2 commits into from
Aug 23, 2024

Conversation

macMikey
Copy link
Contributor

@macMikey macMikey commented Aug 6, 2024

syntax for both eloquence program files and eloquence dialog files
https://eloquence.marxmeier.com/

syntax for both eloquence program files and eloquence dialog files
https://eloquence.marxmeier.com/
@braver
Copy link
Collaborator

braver commented Aug 15, 2024

Please use the checklist in the PR template to tell us about your package.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Eloquence Syntax
Results help

Packages added:
  - Eloquence Syntax

Processing package "Eloquence Syntax"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: eloquence.sublime-syntax

@macMikey
Copy link
Contributor Author

is this what you mean? i did not see the template, so i copied the template from another PR

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

there are no extraneous files or directories in the repo, so, there is no need for .gitattributes

@braver
Copy link
Collaborator

braver commented Aug 21, 2024

@braver
Copy link
Collaborator

braver commented Aug 21, 2024

In captures, you don't need to put quotes around the indexes. Also please ensure all scopes end with .eq (matching "source.eq"). Also please double check the guidelines, you might be able to specify some of those keywords. E.g.:

captures:
        1: keyword.control.eq
        2: entity.name.function.eq

repository/e.json Outdated Show resolved Hide resolved
@macMikey
Copy link
Contributor Author

Was this intended to be a syntax file too? https://github.com/macMikey/eloquence-sublime-text-syntax/blob/main/dlg-sublime-syntax.yaml

there are two types of eloquence files: eloquence program files (.eq), and eloquence dialog files (.dlg). they are supposed to be included.

@macMikey
Copy link
Contributor Author

thanks for your patience, i'm a package n00b

@braver
Copy link
Collaborator

braver commented Aug 21, 2024

You'll probably want to rename dlg-sublime-syntax.yaml to dlg.sublime-syntax then.

thanks for your patience, i'm a package n00b

No worries, that's what we're here for 😉

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Eloquence
Results help

Packages added:
  - Eloquence

Processing package "Eloquence"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: eloquence.sublime-syntax

@macMikey
Copy link
Contributor Author

macMikey commented Aug 21, 2024

You'll probably want to rename dlg-sublime-syntax.yaml to dlg.sublime-syntax then.

thanks for your patience, i'm a package n00b

No worries, that's what we're here for 😉

done. thanks, again.

@braver
Copy link
Collaborator

braver commented Aug 21, 2024

Alright, main thing then remains that all scopes need to end with the identifier of the syntax, ie. keyword.dlg and keyword.eq, etc. This makes it possible for package developers to target your specific syntax.

@braver braver added the mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side label Aug 21, 2024
@macMikey
Copy link
Contributor Author

so: in the .dlg syntax file, all of the scopes end in .dlg and in the .eq file, all the scopes end in .eq?

@braver
Copy link
Collaborator

braver commented Aug 22, 2024

Yes. Basically your base scope for a syntax is source.XX and then you make sure all the scopes in that syntax also end with .XX

@macMikey
Copy link
Contributor Author

just pushed 0.0.2. is that what i should be doing? i took every scope line, and ended the label with .eq

@braver
Copy link
Collaborator

braver commented Aug 22, 2024

Almost!

source.dlg.eq should still be source.dlg

Also remember that your captures also assign scopes, so you need to cover those as well.

Have a look at some example syntaxes like https://github.com/sublimehq/Packages/blob/master/CSS/CSS.sublime-syntax#L3216C1-L3224C43

@macMikey
Copy link
Contributor Author

  • source.dlg updated
  • captures updated

thanks for all the help.

@braver
Copy link
Collaborator

braver commented Aug 23, 2024

Looks good!

@braver braver merged commit f1bae7d into wbond:master Aug 23, 2024
2 checks passed
@macMikey
Copy link
Contributor Author

thanks for all the help.
package-control n00b...out

@braver
Copy link
Collaborator

braver commented Aug 23, 2024

🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants