-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eloquence syntax #8956
eloquence syntax #8956
Conversation
syntax for both eloquence program files and eloquence dialog files https://eloquence.marxmeier.com/
Please use the checklist in the PR template to tell us about your package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Eloquence Syntax
Results help
Packages added:
- Eloquence Syntax
Processing package "Eloquence Syntax"
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: eloquence.sublime-syntax
is this what you mean? i did not see the template, so i copied the template from another PR
there are no extraneous files or directories in the repo, so, there is no need for .gitattributes |
Was this intended to be a syntax file too? https://github.com/macMikey/eloquence-sublime-text-syntax/blob/main/dlg-sublime-syntax.yaml |
In captures, you don't need to put quotes around the indexes. Also please ensure all scopes end with captures:
1: keyword.control.eq
2: entity.name.function.eq |
there are two types of eloquence files: eloquence program files (.eq), and eloquence dialog files (.dlg). they are supposed to be included. |
thanks for your patience, i'm a package n00b |
You'll probably want to rename dlg-sublime-syntax.yaml to
No worries, that's what we're here for 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Eloquence
Results help
Packages added:
- Eloquence
Processing package "Eloquence"
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: eloquence.sublime-syntax
done. thanks, again. |
Alright, main thing then remains that all scopes need to end with the identifier of the syntax, ie. |
so: in the .dlg syntax file, all of the scopes end in .dlg and in the .eq file, all the scopes end in .eq? |
Yes. Basically your base scope for a syntax is source.XX and then you make sure all the scopes in that syntax also end with .XX |
just pushed 0.0.2. is that what i should be doing? i took every scope line, and ended the label with .eq |
Almost! source.dlg.eq should still be source.dlg Also remember that your captures also assign scopes, so you need to cover those as well. Have a look at some example syntaxes like https://github.com/sublimehq/Packages/blob/master/CSS/CSS.sublime-syntax#L3216C1-L3224C43 |
thanks for all the help. |
Looks good! |
thanks for all the help. |
🫡 |
syntax for both eloquence program files and eloquence dialog files
https://eloquence.marxmeier.com/