Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l.json #8964

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Update l.json #8964

merged 2 commits into from
Sep 19, 2024

Conversation

JohhannasReyn
Copy link
Contributor

Add Lensort package

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...
Unique, I haven't found anything that sorts lines by length, which is why I wrote it.
There are no packages like it in Package Control.

Add Lensort package
@braver
Copy link
Collaborator

braver commented Sep 3, 2024

SortBy can "Sort by the length of lines". I'm not against a package that only does sorting by length though, I kind of like that focus actually.

  • You still need to tag a release (e.g. 1.0.0), that's also why the tests fail.
  • Your preferences menu still has separate entries for User and Default settings... that went out of vogue ages ago ;) Use the edit_settings command there just like you do in sublime-commands.
  • Since you ship with example key bindings, it would be a good idea to include keybindings in the preferences menu, and in the command palette.
  • In my experience, users don't really like update messages unless they mention something important. If a user just installed your package, a 1.0.0 message might do a lot other than confirmed it worked (which package control also does).
  • There should not be a package-metadata.json file in your repo. The metadata is in this entry here in package control.

@JohhannasReyn
Copy link
Contributor Author

I've made the corrections you have listed; I believe it's ready to be reviewed again. Thank you.

Fixed indentation issue
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Lensort
Results help

Packages added:
  - Lensort

Processing package "Lensort"
  - ERROR: 'package-metadata.json' is supposed to be automatically generated by Package Control during installation
  - ERROR: File 'Initial release of Lensort, a line sorting plugin for Sublime Text with whitespace management features.', as specified by key '1.0.0', does not exist
    - File: messages.json

@braver
Copy link
Collaborator

braver commented Sep 6, 2024

@JohhannasReyn please tag a release with your latest work.

@braver braver added the mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side label Sep 6, 2024
@JohhannasReyn
Copy link
Contributor Author

@JohhannasReyn please tag a release with your latest work.

I believe I completed this already, no?

@braver
Copy link
Collaborator

braver commented Sep 19, 2024

Looks like!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Lensort

Packages added:
  - Lensort

Processing package "Lensort"
  - All checks passed

@braver braver merged commit 3a8e5af into wbond:master Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants