Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds fight-color-scheme package #8967

Merged
merged 1 commit into from
Sep 7, 2024
Merged

adds fight-color-scheme package #8967

merged 1 commit into from
Sep 7, 2024

Conversation

ghyatzo
Copy link
Contributor

@ghyatzo ghyatzo commented Sep 2, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Fight Color Scheme
Results help

Packages added:
  - Fight Color Scheme

Processing package "Fight Color Scheme"
  - WARNING: Creating a readme for your package will help users understand what it does and how to use it

@braver
Copy link
Collaborator

braver commented Sep 3, 2024

You should add a README to explain your package to users. And for a color scheme it's really helpful to put a screenshot in there: what it looks like is basically the only thing that matters ;)

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Sep 3, 2024
@ghyatzo
Copy link
Contributor Author

ghyatzo commented Sep 4, 2024

Oh duh. I forgot to push it, will do. Thanks.

@braver
Copy link
Collaborator

braver commented Sep 6, 2024

@ghyatzo please ping me when you've done so, so that we can merge this.

@ghyatzo
Copy link
Contributor Author

ghyatzo commented Sep 6, 2024

Yes I am sorry. Got sidetracked with a million things. Tomorrow I will have some free time.

@ghyatzo
Copy link
Contributor Author

ghyatzo commented Sep 7, 2024

@braver it's up. Thank you for your patience

@braver
Copy link
Collaborator

braver commented Sep 7, 2024

Remember that package control only looks at your tags, so create a new tag whenever you’ve made some changes.

@braver braver merged commit e2ad9c3 into wbond:master Sep 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants