Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates p.josn, Added Piranha syntax highlighter. #8970

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

Kostasn2
Copy link
Contributor

@Kostasn2 Kostasn2 commented Sep 10, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is a syntax highlighter for Piranha scripting language library.

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Piranha
Results help

Packages added:
  - Piranha

Processing package "Piranha"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Piranha.sublime-syntax

Copy link
Collaborator

@braver braver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things:

  • source.mr feels odd to me, I would've expected source.piranha? also since your reference that elsewhere
  • I would recommend adding tests. It's easy and makes it a lot easier to make changes later

repository/p.json Outdated Show resolved Hide resolved
Co-authored-by: Koen Lageveen <[email protected]>
@Kostasn2
Copy link
Contributor Author

Looks good, just some minor things:

  • source.mr feels odd to me, I would've expected source.piranha? also since your reference that elsewhere
  • I would recommend adding tests. It's easy and makes it a lot easier to make changes later

Ok ok, i also changed that!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Piranha
Results help

Packages added:
  - Piranha

Processing package "Piranha"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Piranha.sublime-syntax

@braver braver merged commit 03123d0 into wbond:master Sep 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants