Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): should catch build errors #1938

Merged
merged 1 commit into from
Mar 11, 2025
Merged

fix(cli): should catch build errors #1938

merged 1 commit into from
Mar 11, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Should catch build errors when running the build() method.

before

Screenshot 2025-03-11 at 13 32 32

after

Screenshot 2025-03-11 at 13 40 15

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 294bc6b
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67cfcdfa97336800087757b8
😎 Deploy Preview https://deploy-preview-1938--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 294bc6b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67cfcdfa9505bf0008377588
😎 Deploy Preview https://deploy-preview-1938--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from SoonIter March 11, 2025 05:45
@SoonIter SoonIter enabled auto-merge (squash) March 11, 2025 05:56
@SoonIter SoonIter merged commit 69a140e into main Mar 11, 2025
12 checks passed
@SoonIter SoonIter deleted the cli_catch_0311 branch March 11, 2025 05:56
@JounQin JounQin mentioned this pull request Mar 11, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants