Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds static year files and updates README.md #1

Merged
merged 6 commits into from
Mar 18, 2025
Merged

Conversation

tonypconway
Copy link
Collaborator

No description provided.

@tonypconway
Copy link
Collaborator Author

Hey @notpushkin I've created this as a PR so you can see the changes before I merge. This adds static year config files and versions that include downstream Chromium browsers that are currently available in baseline-browser-mapping.

Let me know if you have any objections or suggested changes to this as it exists. Next on my to-do list are:

  • Create a script that automatically updates the index.js files that return Widely Available so that they are updated whenever the minimum Widely Available versions change.
  • Set up a GitHub action that executes that script and then auto-publishes if there are changes.
  • Add some logic to those files that give a console warning if the user is using an old version of the package so that people don't end up out of date/forget to include npm i browserslist-config-baseline@latest in their build scripts.

Something other than public domain is a common requirement for folks
working at software companies to contribute to OSS projects.
@tonypconway
Copy link
Collaborator Author

@notpushkin FYI, I've swapped the license to Apache-2.0 because I (and I imagine others contributing on behalf of software companies) can't work on public domain projects. It's also the license used for all the other web-platform-dx repositories, so it keeps things harmonious on that front. LMK if you have any strong objections to that.

@notpushkin
Copy link
Collaborator

@tonypconway Apache-2.0 is fine by me! I didn’t feel like the initial implementation was copyrightable, so I went with the simplest option :-) But given other WebDX projects are Apache-licensed, it only makes sense to stay consistent.

I’ll take a look at the changes in a moment!

tonypconway and others added 3 commits March 18, 2025 15:33
@notpushkin notpushkin self-requested a review March 18, 2025 15:41
Copy link
Collaborator

@notpushkin notpushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when you’re ready! I’ll publish this release manually for now, and we can set up GitHub Actions for the next one.

@tonypconway
Copy link
Collaborator Author

Thanks @notpushkin , merging now!

@tonypconway tonypconway merged commit e47f1da into main Mar 18, 2025
@tonypconway
Copy link
Collaborator Author

tonypconway commented Mar 19, 2025

FYI - I've added a draft release note that we can turn on once you've published. I'm happy to do it myself as I have access now.

Also FYI, we'll need to turn off 2FA auth on the NPM package for GitHub to be able to publish automatically, which we'll want to do to keep Widely Available configs up to date. Let me know if you have any major concerns there.

@tonypconway tonypconway deleted the add-static-years branch March 19, 2025 11:52
@notpushkin
Copy link
Collaborator

notpushkin commented Mar 19, 2025

@tonypconway Sorry – couldn’t find my phone yesterday! I’ve just published it now: https://www.npmjs.com/package/browserslist-config-baseline/v/0.2.0

Also FYI, we'll need to turn off 2FA auth on the NPM package for GitHub to be able to publish automatically

I’ve set it to “Require two-factor authentication or an automation or granular access token”, which I believe should be enough to do releases from CI? (I’ve just created a granular token, will try to set up GitHub Actions now – unless you’re on it already :-)


I’ve tweaked release notes a bit to match style of other projects in this org and make wording a bit simpler. If everything looks okay, you can release it.

(Re: Baseline year feature sets – I’ve reworded it as “yearly Baseline” which sounds less formal, but if it is the official term we can use that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants