-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds static year files and updates README.md #1
Conversation
Hey @notpushkin I've created this as a PR so you can see the changes before I merge. This adds static year config files and versions that include downstream Chromium browsers that are currently available in Let me know if you have any objections or suggested changes to this as it exists. Next on my to-do list are:
|
Something other than public domain is a common requirement for folks working at software companies to contribute to OSS projects.
@notpushkin FYI, I've swapped the license to Apache-2.0 because I (and I imagine others contributing on behalf of software companies) can't work on public domain projects. It's also the license used for all the other web-platform-dx repositories, so it keeps things harmonious on that front. LMK if you have any strong objections to that. |
@tonypconway Apache-2.0 is fine by me! I didn’t feel like the initial implementation was copyrightable, so I went with the simplest option :-) But given other WebDX projects are Apache-licensed, it only makes sense to stay consistent. I’ll take a look at the changes in a moment! |
Co-authored-by: Alexander Pushkov <[email protected]>
Co-authored-by: Alexander Pushkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when you’re ready! I’ll publish this release manually for now, and we can set up GitHub Actions for the next one.
Thanks @notpushkin , merging now! |
FYI - I've added a draft release note that we can turn on once you've published. I'm happy to do it myself as I have access now. Also FYI, we'll need to turn off 2FA auth on the NPM package for GitHub to be able to publish automatically, which we'll want to do to keep Widely Available configs up to date. Let me know if you have any major concerns there. |
@tonypconway Sorry – couldn’t find my phone yesterday! I’ve just published it now: https://www.npmjs.com/package/browserslist-config-baseline/v/0.2.0
I’ve set it to “Require two-factor authentication or an automation or granular access token”, which I believe should be enough to do releases from CI? (I’ve just created a granular token, will try to set up GitHub Actions now – unless you’re on it already :-) I’ve tweaked release notes a bit to match style of other projects in this org and make wording a bit simpler. If everything looks okay, you can release it. (Re: Baseline year feature sets – I’ve reworded it as “yearly Baseline” which sounds less formal, but if it is the official term we can use that.) |
No description provided.