Add back the label removed in #7198 #7209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Another weird thing from #7198 is that the .any.js file was added to the end of the list instead of in the right sorting order, so maybe it was just a mistake to include it and we should discard this PR? |
foolip
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
The sequence of events here in wpt-metadata is a bit hard to follow, but I think this is the right fix. We labeled the test in #5478 and it was renamed in web-platform-tests/wpt#50380.
Since only the window variant was initially labeled, labeling only that one still makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduled manifest update hit a snag with this commit, which included
idbrequest-onupgradeneeded.any.js. I removed the offending line to merge #7198 and ran a subsequent update (#7208) that didn't add it back.I assume that this PR adds the correct test to the Interop label, but maybe the intent was to add the entire exploded set (including the worker tests)?