URLPattern: Throw on more illegal hostname code points. #30471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2021
As discussed in the mozilla standards-position issue on URLPattern: mozilla/standards-positions#566 There are a number of URL encoding interop issues between browsers. Since URLPattern delegates to the URL parser for canonicalization it is also exposed to these interop issues. While fixing all of URL's interop issues is orthogonal to shipping URLPattern, we can at least prevent clearly illegal code points from being used in URLPattern. This will avoid increasing usage of these code points which will in turn make it slightly easier to fix the issue in the URL parser in the future. Bug: 1248061 Change-Id: I58a55e4206004a6cba727f19d537c5929ce16d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152036 Reviewed-by: Jeremy Roman <[email protected]> Commit-Queue: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#920223}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3152036
branch
from
443321f to
b9f2777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the mozilla standards-position issue on URLPattern:
mozilla/standards-positions#566
There are a number of URL encoding interop issues between browsers.
Since URLPattern delegates to the URL parser for canonicalization it
is also exposed to these interop issues.
While fixing all of URL's interop issues is orthogonal to shipping
URLPattern, we can at least prevent clearly illegal code points from
being used in URLPattern. This will avoid increasing usage of these
code points which will in turn make it slightly easier to fix the issue
in the URL parser in the future.
Bug: 1248061
Change-Id: I58a55e4206004a6cba727f19d537c5929ce16d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152036
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#920223}