Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emscripten-only extension; slightly reorder SType #320

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Aug 26, 2024

Emscripten will keep this (under the new name) but it's not "standardized" in this header yet.

All of the SurfaceSource extensions are going to get moved into the 0x0001_???? block (they're already moved in Dawn but we haven't moved them in here yet).

So reordering these puts the other 3 STypes in the exact positions I think they'll be when the header becomes stable.

Issue: #214 (comment)

@beaufortfrancois
Copy link
Contributor

Out of curiosity, what was the logic for reordering SType?

@kainino0x
Copy link
Collaborator Author

kainino0x commented Aug 30, 2024

All of the SurfaceSource extensions are going to get moved into the 0x0001_???? block (they're already moved in Dawn but we haven't moved them in here yet).

So reordering these puts the other 3 STypes in the exact positions I think they'll be when the header becomes stable.

@kainino0x kainino0x merged commit f020689 into webgpu-native:main Aug 30, 2024
4 checks passed
@kainino0x kainino0x deleted the no-emscripten branch August 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants