Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for banner admin page #5424

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Improve UX for banner admin page #5424

merged 1 commit into from
Mar 8, 2025

Conversation

itsisak
Copy link
Contributor

@itsisak itsisak commented Mar 7, 2025

Description

Display the banner and improve UX for selecting public/private banners

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.


Description Before After
Complete overhaul of the design

Screenshot 2025-03-07 at 19 10 47

Screenshot 2025-03-07 at 19 10 05

Testing

  • I have thoroughly tested my changes.

@itsisak itsisak added the review-needed Pull requests that need review label Mar 7, 2025
@itsisak itsisak self-assigned this Mar 7, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Mar 7, 2025 6:20pm

jonasdeluna
jonasdeluna approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, maybe some way to display the link onhover or something?

@itsisak
Copy link
Contributor Author

itsisak commented Mar 7, 2025

This is great, maybe some way to display the link onhover or something?

I believe most browsers do this.. also you can see the link when you edit it

ivarnakken
ivarnakken approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! 😍 😍

ch0rizo
ch0rizo approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it isn't a trojan horse🧐🐴

@jonasdeluna jonasdeluna merged commit 4c3947e into master Mar 8, 2025
8 checks passed
@jonasdeluna jonasdeluna deleted the redesign-banner-admin-page branch March 8, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

@jonasdeluna jonasdeluna jonasdeluna approved these changes

@ch0rizo ch0rizo ch0rizo approved these changes

@eikhr eikhr Awaiting requested review from eikhr

Assignees

@itsisak itsisak

Labels
review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsisak @ivarnakken @jonasdeluna @ch0rizo