-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper for creating MLOperandDescriptor to simplify steps #737
Conversation
The only non-trivial bits are a few cases where in the previous steps the shape was calculated after the MLOperandDescriptor was created, but this would not be an observable change to script.
Deleting lines is good! This should be pretty straightforward. @huningxin & @fdwr can you please review? |
This would also simplify #676 significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should cut down on the tedium some. Looks good with one addition.
Co-authored-by: Ningxin Hu <[email protected]>
Also, retain usage of "bidirectionally broadcastable"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 TY. Fixing a small typo and merging.
SHA: bd5da6b Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The only non-trivial bits are a few cases where in the previous steps the shape was calculated after the MLOperandDescriptor was created, but this would not be an observable change to script.
Preview | Diff