Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): update typescript setup in configuration-languages.mdx #6929

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

piouson
Copy link
Contributor

@piouson piouson commented Jun 23, 2023

import * not required when esModuleInterop: true in tsconfig.json.

{
  "devDependencies": {
    "@types/node": "^20.3.1",
    "@types/webpack": "^5.28.1",
    "@types/webpack-dev-server": "^4.7.2",
    "ts-loader": "^9.2.6",
    "ts-node": "^10.9.1",
    "typescript": "^5.1.3",
    "webpack": "^5.88.0",
    "webpack-cli": "^5.1.4",
    "webpack-dev-server": "^4.7.4"
  }
}

@vercel
Copy link

vercel bot commented Jun 23, 2023

@piouson is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@piouson piouson force-pushed the docs/update-configuration-languages branch from a0cc1f4 to 890b34a Compare June 23, 2023 23:07
`import *` not required when `esModuleInterop: true` in `tsconfig.json`.

```json
{
  "devDependencies": {
    "@types/node": "^20.3.1",
    "@types/webpack": "^5.28.1",
    "@types/webpack-dev-server": "^4.7.2",
    "ts-loader": "^9.2.6",
    "ts-node": "^10.9.1",
    "typescript": "^5.1.3",
    "webpack": "^5.88.0",
    "webpack-cli": "^5.1.4",
    "webpack-dev-server": "^4.7.4"
  }
}
```
@piouson piouson force-pushed the docs/update-configuration-languages branch from 890b34a to 860b994 Compare June 23, 2023 23:08
@piouson piouson changed the title Update typescript setup in configuration-languages.mdx docs(config): update typescript setup in configuration-languages.mdx Jun 23, 2023
@vercel
Copy link

vercel bot commented Jun 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ❌ Failed (Inspect) Mar 19, 2024 2:20pm

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chenxsan chenxsan merged commit 7a56e55 into webpack:main Jun 27, 2023
6 checks passed
@piouson piouson deleted the docs/update-configuration-languages branch June 28, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants