Add option to push behavior + behavior script logs to Redis #805
+90
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
changed the title
tw4l
changed the title
tw4l
force-pushed
the
issue-804-behavior-logs-redis
branch
2 times, most recently
from
761b966 to
08e34e4
Compare
tw4l
force-pushed
the
issue-804-behavior-logs-redis
branch
from
08e34e4 to
66bd6e3
Compare
- add 'behaviorScriptCustom' log context if siteSpecific is set - move 'msg' to main message field if present in behavior log object
tw4l
commented
Apr 2, 2025
Comment on lines
+1504
to
+1506
| // TODO: Remove before merging, just for testing | ||
| const behaviorsLoggedToRedis = await this.crawlState.getBehaviorList(); | ||
| logger.info("Behavior lines logged to Redis", { behaviorsLoggedToRedis }); |
There was a problem hiding this comment.
Suggested change
| // TODO: Remove before merging, just for testing | |
| const behaviorsLoggedToRedis = await this.crawlState.getBehaviorList(); | |
| logger.info("Behavior lines logged to Redis", { behaviorsLoggedToRedis }); |
tw4l
commented
Apr 2, 2025
Comment on lines
+881
to
+885
| // TODO: Remove before merging, just for testing | ||
| async getBehaviorList() { | ||
| return await this.redis.lrange(this.bkey, 0, -1); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // TODO: Remove before merging, just for testing | |
| async getBehaviorList() { | |
| return await this.redis.lrange(this.bkey, 0, -1); | |
| } |
tw4l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804
Noisy logs from built-in behaviors like autoscroll are now logged to debug in webrecorder/browsertrix-behaviors#92 and so won't be pushed to Redis for newer versions of the crawler.
We should also bump browsertrix-behaviors to 0.8.2 after webrecorder/browsertrix-behaviors#92 is merged.