Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: add docker template to CLI #4744

Merged
merged 6 commits into from
Jan 19, 2025
Merged

experimental: add docker template to CLI #4744

merged 6 commits into from
Jan 19, 2025

Conversation

TrySound
Copy link
Member

Here added first react-router template which additionally adds docker support. For now only adds Dockerfile + .dockerignore. Will add support for image transforms separately.

Mostly duplicated defaults template

  • replaced remix packages with react-router ones
  • replaced return redirect() with throw redirect()

The template for now is self contained. Will split base react-router template when will add more integrations.

@TrySound TrySound requested review from kof and istarkov January 13, 2025 09:31
@TrySound TrySound force-pushed the react-router-docker branch from 73428e3 to 45bc3fe Compare January 17, 2025 09:50
Here added first react-router template which additionally adds docker
support. For now only adds Dockerfile + .dockerignore. Will add support
for image transforms separately.
@TrySound TrySound force-pushed the react-router-docker branch from 3151173 to d0eee09 Compare January 19, 2025 06:58
@TrySound TrySound merged commit 1f48985 into main Jan 19, 2025
15 checks passed
@TrySound TrySound deleted the react-router-docker branch January 19, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants