-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #961: Remove root_dir args and visualization from evaluate_image_boxes and evaluate_boxes function #964
base: main
Are you sure you want to change the base?
Conversation
Under review: ff66fac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Samia35-2973 for getting to work on this issue. I expected some changes in the tests too.
Thank you for the feedback @henrykironde. I am working on the test cases. |
All tests pass locally after these updates. Please let me know if anything needs further clarification or if there are any additional changes you'd like me to make. |
savedir=tmpdir) | ||
assert all([os.path.exists("{}/{}".format(tmpdir, x)) for x in ground_truth.image_path]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the evaluate.py file, the evaluate_boxes()
only saves images if the root_dir
is provided to locate the original image files. As I removed the root_dir
from this function and the evaluate_image_boxes()
function, Image.open()
cannot load the original image, so no files are saved. The assertion checked for images which were created only if root_dir was provided. As a result, the test was failing after the removal of root_dir
.
This addresses issue #961 by making the following changes: