Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made SNMP privacy protocol selectable #41

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

dommi22m
Copy link
Contributor

This is my version to make the privacy protocol selectable. AES128 is used as default.

Copy link
Owner

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.

Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?

@dommi22m
Copy link
Contributor Author

dommi22m commented Aug 16, 2022

Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.

Done!

Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?

Yes you are right! I was thinking in the direction of "secret". But that would not be logical and also wrong in terms of content.

Copy link
Owner

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small whitespace fix, rest LGTM 👍🏻

README.md Outdated Show resolved Hide resolved
@wernerfred
Copy link
Owner

@all-contributors add @dommi22m for code

@allcontributors
Copy link
Contributor

@wernerfred

I've put up a pull request to add @dommi22m! 🎉

@wernerfred wernerfred merged commit 5aa3221 into wernerfred:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants