-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made SNMP privacy protocol selectable #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Please add the new option [-s [AES128|DES]]
to the usage in the README.md
accordingly.
Why specifically did you choose -s
? Maybe we should change this to -e
(encryption?) to save -s
for future usecases that are more related to the letter s
? What's your opinion on that?
Done!
Yes you are right! I was thinking in the direction of "secret". But that would not be logical and also wrong in terms of content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small whitespace fix, rest LGTM 👍🏻
@all-contributors add @dommi22m for code |
I've put up a pull request to add @dommi22m! 🎉 |
This is my version to make the privacy protocol selectable. AES128 is used as default.